Skip to content

feat: provide ctx.signal #7878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 5, 2025
Merged

feat: provide ctx.signal #7878

merged 18 commits into from
May 5, 2025

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Apr 23, 2025 •
edited
Loading

Description

Fixes #7647

This PR provides a signal value to the test context. Signal can be aborted by Vitest when:

  • Current run is aborted with CTRL+C
  • Test times out
  • --bail cancels test run

Test plan:

  1. timeout in a normal test aborts the signal
  2. timeout in multiple concurrent tests aborts all signals
  3. cancelCurrentRun aborts the signal in a single test
  4. cancelCurrentRun aborts the signal in a multiple concurrent tests

@sheremet-va sheremet-va added this to the 3.2.0 milestone Apr 23, 2025
@sheremet-va sheremet-va marked this pull request as ready for review April 24, 2025 15:13
@sheremet-va sheremet-va added the p2-nice-to-have Not breaking anything but nice to have (priority) label Apr 24, 2025
@sheremet-va sheremet-va moved this to P2 - 5 in Team Board Apr 24, 2025
@sheremet-va sheremet-va requested a review from AriPerkkio April 24, 2025 15:13
@netlify Netlify
Copy link

netlify bot commented Apr 24, 2025 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit ce6c13b
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6818c82da5eade0008c7321a
😎 Deploy Preview https://deploy-preview-7878--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sheremet-va
sheremet-va commented Apr 24, 2025
View reviewed changes
sheremet-va
sheremet-va commented Apr 24, 2025
View reviewed changes
sheremet-va
sheremet-va commented Apr 24, 2025
View reviewed changes
sheremet-va
sheremet-va commented Apr 24, 2025
View reviewed changes
AriPerkkio
AriPerkkio reviewed Apr 29, 2025
View reviewed changes
test/cli/test/signal.test.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test cases! 🤩

@sheremet-va sheremet-va moved this from P2 - 5 to Approved in Team Board May 1, 2025
@sheremet-va sheremet-va merged commit e761f27 into vitest-dev:main May 5, 2025
6 checks passed
@sheremet-va sheremet-va deleted the feat/provide-signal branch May 5, 2025 14:16
deot added a commit to deot/http that referenced this pull request May 29, 2025
@deot
ci: log test
ff4bf64 
vitest-dev/vitest#7878 后续升级至3.2.0可移除
deot added a commit to deot/http that referenced this pull request May 29, 2025
@deot
ci: use [email protected]
537090e 
vitest-dev/vitest#7878
后续修复再放开
deot added a commit to deot/http that referenced this pull request May 29, 2025
@deot
ci: use [email protected]
8301b85 
vitest-dev/vitest#7878
后续修复再放开
@ghengeveld ghengeveld mentioned this pull request Jun 24, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AriPerkkio AriPerkkio AriPerkkio left review comments

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
Team Board
Archived in project
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

AbortSignal in tests on run cancel
2 participants
@sheremet-va @AriPerkkio