feat: deprecate update() in favor of updateConfiguration() #2142
Conversation
| chart.setAttribute('category-min', newCategoryMin); | ||
| }); | ||
|
|
||
| it('should warn when setting a not valid minimum value', () => { |
There was a problem hiding this comment.
It was an attempt to improve the chart's code coverage, but it didn't significantly change the numbers (+0.25%). I decided not to throw away the created test from the PR anyway.
| chart.setAttribute('category-max', newCategoryMax); | ||
| }); | ||
|
|
||
| it('should warn when setting a not valid maximum value', () => { |
There was a problem hiding this comment.
It was an attempt to improve the chart's code coverage, but it didn't significantly change the situation (+0.25%). I decided not to throw away the created test from the PR anyway.
|
All the tests pass, there is only the problem with the chart's code coverage which in fact is well-known and not associated with the PR:
|
|
Kudos, SonarCloud Quality Gate passed!
|
Description
LitElement reserves the
update()method so that we cannot use it to update chart configuration anymore.This PR deprecates
update()and introducesupdateConfiguration()instead. Though callingupdate()still updates chart configuration, now it shows a deprecation warning as well.Part of #73 (issue)
Type of change
Checklist