Rename render() and update() methods in components

[web-padawan]

As we are going to convert components to Polymer 3 and then gradually move to LitElement in minors, we should rename render method used by some components that have renderer, because it's reserved by LitElement.

[web-padawan]

Note: also update() method used in vaadin-charts.

[web-padawan]

Affected components:

render()

• vaadin-overlay
• vaadin-dialog
• vaadin-select
• vaadin-grid
• vaadin-context-menu
• vaadin-combo-box
• vaadin-notification

update()

• vaadin-chart

[web-padawan]

We should also check for callJsFunction in Flow components, I found at least those:

• Chart
• ComboBox
• Notification
• Select

[vlukashov]

Suggestion for a new name: runRenderers() instead of render() and updateConfiguration() instead of update()

[rolfsmeds]

These methods will be deprecated in V21, with the intent of dropping them in V22. We realize this will constitute a breaking change for those upgrading to V22, but it's necessary for us to be able to convert from Polymer to Lit in minor versions without introducing breaking changes there.

[vursen]

To recap our discussion, have we agreed not to add any deprecation warnings? Seems that we didn't write down our decision.

These methods will be deprecated in V21, with the intent of dropping them in V22. We realize this will constitute a breaking change for those upgrading to V22, but it's necessary for us to be able to convert from Polymer to Lit in minor versions without introducing breaking changes there.

Is it an example of a warning message or just a comment? :)

[vlukashov]

In V21 I expect the following:

1. (when using this method in TypeScript) this method should appear as deprecated
2. (when using this method from JavaScript) calling this method should log a warning to the browser console

The deprecation message is up to you to decide on, but it should be along the lines of

Since Vaadin 21, render() is deprecated. Please use runRenderers() instead.

[vursen]

Great, thanks for the clarification!