Skip to content

fix: check if grid column is attached #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2021
Merged

fix: check if grid column is attached #195

merged 3 commits into from
Apr 7, 2021

Conversation

tulioag
Copy link
Contributor

@tulioag tulioag commented Apr 6, 2021 •
edited by vursen
Loading

Description

Fixes vaadin/vaadin-grid#1981

The error is caused by the grid manually invoking notifyPath for all columns regardless if they're detached or not. This fix adds a check that the column is attached.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@tulioag tulioag requested a review from tomivirkki April 6, 2021 17:18
tomivirkki
tomivirkki reviewed Apr 7, 2021
View reviewed changes
@web-padawan web-padawan changed the title Fix: Check if column is attached fix: check if grid column is attached Apr 7, 2021
@tulioag tulioag merged commit bfed11c into master Apr 7, 2021
@web-padawan web-padawan deleted the fix/vaadin-grid/1981/JS_error_occurs_when_grid_columns_are_re_created branch April 7, 2021 12:33
@tulioag tulioag mentioned this pull request Apr 7, 2021
Merged
tulioag added a commit to vaadin/vaadin-grid that referenced this pull request Apr 7, 2021
@tulioag
fix: check if grid column is attached (#2159)
a0ffd36 
Fixes: #1981
Warranty: Prevent an exception when changing the size after removing columns
Cherrypick: vaadin/web-components#195
@tulioag tulioag mentioned this pull request Apr 8, 2021
Merged
tulioag added a commit to vaadin/vaadin-grid that referenced this pull request Apr 8, 2021
@tulioag
fix: check if grid column is attached (#2160)
9f45ec4 
cherry-pick: check if grid column is attached (vaadin/web-components#195)

Fixes: #1981
Warranty: Prevent an exception when changing the size after removing columns
This was referenced May 4, 2021
Closed
Closed
This was referenced Jun 1, 2021
Closed
Closed
This was referenced Jul 23, 2021
Closed
Closed
This was referenced Aug 6, 2021
Closed
Closed
This was referenced Aug 23, 2021
Closed
Closed
This was referenced Sep 1, 2021
Closed
Closed
Closed
This was referenced Sep 13, 2021
Closed
Closed
This was referenced Sep 21, 2021
Closed
Closed
This was referenced Oct 7, 2021
Closed
Closed
Closed
Closed
This was referenced Nov 15, 2021
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Nov 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS error occurs when grid columns are re-created
2 participants
@tulioag @tomivirkki