JS error occurs when grid columns are re-created

[onuridrisoglu]

I have a use case, where grid columns are dynamically created each time user makes some selection in the view.
Normally it works fine, but when the columns are re-created, if also a new row should be added, then the following error appears: Cannot read property '__getRowModel' of undefined

It seems to be because of vaadin-grid-column's grid property is not set.

Here is a sample code to reproduce the issue:

private Grid<Bean> grid;
private List<Bean> beans;

public SampleGridTest() {
	grid = new Grid<>();
	beans = new ArrayList<>();
	beans.add(new Bean("Hello"));
	Button addButton = new Button("add");
	addButton.addClickListener(evt -> {
		beans.add(new Bean("Hello"));
		grid.removeAllColumns();
		grid.addColumn(Bean::getValue).setHeader("Bean");
		grid.setDataProvider(DataProvider.ofCollection(beans));
	});
	grid.addColumn(Bean::getValue).setHeader("Bean");
	grid.setDataProvider(DataProvider.ofCollection(beans));
	add(grid, addButton);
}

Vaadin version : 13.0.1
Browser : Chrome Version 72

[mlopezFC]

I don't know if it could be related or not, but it seems to be a relationship (also) with setItemDetailsRenderer(). The following code works, but if that line is uncommented, then the same error appears:

@Route("grid")
public class GridView extends VerticalLayout {
	public GridView() {
		setWidthFull();
		setHeight("80%");
		final Grid<String> grid = new Grid<>();
		grid.setItems("Row 1", "Row 2", "Row 3");
		grid.addColumn(row -> "Column");
		grid.setSizeFull();
		Button b = new Button("Enable item details renderer");
		b.addClickListener(ev->{
			grid.removeAllColumns();
			grid.addColumn(row -> "Column 2");
//			grid.setItemDetailsRenderer(TemplateRenderer.<String>of("<div>Hello world</div>"));
		});
		add(grid,b);
	}
}

[martinisraelsen]

I'm experiencing this issue as well. Vaadin 14.4.2

[tomivirkki]

The error is caused by the grid manually invoking notifyPath for all columns regardless if they're detached or not. This can be fixed by also checking that the column element is connected for example with c => c.parentElement && c.notifyPath && ...