Skip to content

Conversation

@jouni
Copy link
Member

@jouni jouni commented Sep 16, 2025

Allow developers to choose if they want to show the indicator at the top, bottom, or both edges of Scroller and Virtual List.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure why the previous visual test references screenshots didn't show the scrollbars. The one where both indicators are shown still doesn't show the scrollbars 🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have hide-scrollbars.js file but IMO it can be removed. I'll handle that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: removed that file from base styles but preserved for Lumo since it is tested with older Chrome version where scrollbars make the appearance of the indicators less obvious (I believe that’s the reason why they were hidden).

@jouni jouni requested a review from web-padawan September 16, 2025 08:27
@web-padawan web-padawan force-pushed the feat/scroller-overflow-indicators branch from ee4ef2f to b2b2461 Compare September 16, 2025 09:03
@sonarqubecloud
Copy link

@web-padawan web-padawan merged commit bbc612e into main Sep 16, 2025
9 checks passed
@web-padawan web-padawan deleted the feat/scroller-overflow-indicators branch September 16, 2025 09:51
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-alpha12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants