Skip to content

Commit b2b2461

Browse files
committed
feat: update Lumo scroller to also add new overflow variants
1 parent d594833 commit b2b2461

File tree

7 files changed

+5
-5
lines changed

7 files changed

+5
-5
lines changed
557 Bytes
Loading

packages/scroller/test/visual/hide-scrollbar.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themab
44
registerStyles(
55
'vaadin-scroller',
66
css`
7-
:host([theme~='overflow-indicators'])::-webkit-scrollbar {
7+
:host([theme*='overflow-indicator'])::-webkit-scrollbar {
88
display: none;
99
}
1010
`,
-4.88 KB
Loading
-4.87 KB
Loading
-4.87 KB
Loading

packages/scroller/test/visual/lumo/scroller.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ describe('scroller', () => {
3333
});
3434

3535
it('theme-overflow-indicators-bottom', async () => {
36-
element.setAttribute('theme', 'overflow-indicators');
36+
element.setAttribute('theme', 'overflow-indicator-bottom');
3737
await visualDiff(div, 'theme-overflow-indicators-bottom');
3838
});
3939

@@ -44,7 +44,7 @@ describe('scroller', () => {
4444
});
4545

4646
it('theme-overflow-indicators-top', async () => {
47-
element.setAttribute('theme', 'overflow-indicators');
47+
element.setAttribute('theme', 'overflow-indicator-top');
4848
element.scrollTop = element.scrollHeight - element.clientHeight;
4949
await visualDiff(div, 'theme-overflow-indicators-top');
5050
});

packages/vaadin-lumo-styles/src/components/scroller.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
box-shadow: 0 0 0 var(--_focus-ring-width) var(--_focus-ring-color);
1515
}
1616

17-
:host([theme~='overflow-indicators'])::before,
18-
:host([theme~='overflow-indicators'])::after {
17+
:host([theme*='overflow-indicator'])::before,
18+
:host([theme*='overflow-indicator'])::after {
1919
background: var(--lumo-contrast-10pct);
2020
}
2121
}

0 commit comments

Comments
 (0)