Skip to content

Conversation

yuriy-fix
Copy link
Contributor

Fixes #1703
Requires #1706

@yuriy-fix yuriy-fix changed the title Rtl support resize nav Rtl support resize & navigation Apr 2, 2020
@yuriy-fix yuriy-fix force-pushed the rtl-support-resize-nav branch 2 times, most recently from 3e76e7a to 1b10325 Compare April 7, 2020 13:32
@yuriy-fix yuriy-fix marked this pull request as ready for review April 8, 2020 07:13
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase.

@yuriy-fix yuriy-fix force-pushed the rtl-support-resize-nav branch from 1b10325 to 8b93ebe Compare April 8, 2020 07:31
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Restarted Travis, if the iOS job fails once again will ignore that and merge.

@web-padawan
Copy link
Member

Skipped iOS tests but there are Edge 18 timeouts. Sigh.

https://travis-ci.org/github/vaadin/vaadin-grid/builds/672422248 - green for iOS

https://travis-ci.org/github/vaadin/vaadin-grid/builds/672398773 - green for Edge.

So, in total we have a green build now. Merging.

@web-padawan web-padawan merged commit 1f8e815 into master Apr 8, 2020
@web-padawan web-padawan deleted the rtl-support-resize-nav branch April 8, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement RTL interactions
2 participants