Skip to content

Initial rtl support #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 8, 2020
Merged

Initial rtl support #1706

merged 15 commits into from
Apr 8, 2020

Conversation

yuriy-fix
Copy link
Contributor

Fixes #1490

tomivirkki
tomivirkki reviewed Mar 30, 2020
View reviewed changes
@yuriy-fix yuriy-fix mentioned this pull request Apr 2, 2020
Merged
@yuriy-fix yuriy-fix marked this pull request as ready for review April 2, 2020 12:42
DiegoCardoso
DiegoCardoso requested changes Apr 3, 2020
View reviewed changes
DiegoCardoso
DiegoCardoso reviewed Apr 6, 2020
View reviewed changes
@yuriy-fix
Copy link
Contributor Author

Small DnD note. In the current implementation the count position is still displayed on the right side of the pointer. Is that correct, @mehdi-vaadin?

Compare two screenshots below with the number of dragged rows in red box (ltr and rtl mode):
Screen Shot 2020-04-06 at 14 47 10
Screen Shot 2020-04-06 at 14 46 18

DiegoCardoso
DiegoCardoso reviewed Apr 7, 2020
View reviewed changes
DiegoCardoso
DiegoCardoso reviewed Apr 7, 2020
View reviewed changes
@mehdi-vaadin
Copy link

Small DnD note. In the current implementation the count position is still displayed on the right side of the pointer. Is that correct, @mehdi-vaadin?

IMO, it's totally ok for the count to be on the right. It's more related to the direction of the mouse pointer rather than the direction of the component/page.

DiegoCardoso
DiegoCardoso approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@yuriy-fix yuriy-fix merged commit 67d6d31 into master Apr 8, 2020
@yuriy-fix yuriy-fix deleted the rtl-support branch April 8, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki left review comments

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix RTL issues
4 participants
@yuriy-fix @mehdi-vaadin @DiegoCardoso @tomivirkki