Windows compatibility #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttencate
requested changes
Aug 4, 2025
Owner
ttencate
left a comment
ttencate
left a comment
There was a problem hiding this comment.
Ugh, here I was thinking that bash was weird... turns out cmd is ten times worse :(
Contributor
Author
Agreed, Powershell exists for a reason |
Owner
|
Are you still planning to work on this PR? If you don't have time, I'd be happy to take over and push it across the finish line, but I could still use your help with testing all the weird edge cases. |
Contributor
Author
|
Squash committed all that's needed for it to work! @ttencate |
ttencate
reviewed
Sep 5, 2025
ttencate
reviewed
Sep 8, 2025
…D://) and weird names (e.g. "%%^")
Contributor
Author
|
It should be a-ok now. |
Owner
|
Alright, let's go! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3
Added the current compatibility status, implemented a working cmd.exe call, checked for invalid working directories and improved three things on subprocess.gd. I am not sure if the change on the deferred call is an improvement but it removes the need to use strings, which makes it safer overall.