Skip to content

Pre-filter GitHub v1 findings to prevent large numbers of validation requests #4468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

Pre-filter GitHub v1 findings to prevent large numbers of validation requests #4468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions pkg/detectors/github/v1/github_old.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,14 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result
matchPrefix := match[0]
token := match[1]

// It may seem strange to filter out findings prior to verifying them. However, this credential looks like a
// normal sha256 hash, which is an incredibly common string to see. So the filter here prevents an excessive
// number of requests to be sent for findings which will almost certainly not be verified. It must occur before
// verification, because otherwise the number of verification requests can be quite excessive.
if isKnownNonSensitiveCommonPrefix(matchPrefix) {
continue
}

// Note that this false positive check happens **before** verification! I don't know why it's written this way
// but that's why this logic wasn't moved into a CustomFalsePositiveChecker implementation.
if isFp, _ := detectors.IsKnownFalsePositive(token, ghFalsePositives, false); isFp {
Expand All @@ -120,13 +128,6 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result

isVerified, userResponse, headers, err := s.VerifyGithub(ctx, client, token)

if !isVerified {
// to avoid false positives for unverified findings
if isKnownNonSensitiveCommonPrefix(matchPrefix) {
continue
}
}

s1.Verified = isVerified
s1.SetVerificationError(err, token)

Expand Down
Loading