Skip to content

Conversation

trufflesteeeve
Copy link
Collaborator

Description:

GitHub v1 tokens are unlikely, so verifying them should only be done if we're relatively confident that the sha256 hash we're seeing isn't actually a sha256 hash.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@trufflesteeeve trufflesteeeve requested a review from a team as a code owner September 17, 2025 22:13
Copy link
Contributor

@martinlocklear martinlocklear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes a ton of sense. In one perspective, verification is just another way to filter results, and doing the largest amount of culling early makes sense to me.

@trufflesteeeve trufflesteeeve merged commit 466da5b into main Sep 18, 2025
13 checks passed
@trufflesteeeve trufflesteeeve deleted the move-github-v1-filtering-before-verification branch September 18, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants