Skip to content

Conversation

thenewguy
Copy link
Collaborator

fixes issue #70

@zerolab
Copy link
Member

zerolab commented Nov 11, 2019

These are great, @thenewguy. The test failure is fixed in #63 and my gut feeling is to fold your changes into that PR and commit them together

@thenewguy
Copy link
Collaborator Author

@zerolab Glad to hear it. Are you referencing #69 and #67 as well? Do you want me to make a PR that includes those and #63 with a version increment?

@zerolab
Copy link
Member

zerolab commented Nov 11, 2019

@Chris-May incorporated your PR in #63
Will have a look at the other two tomorrow, if that is ok

@thenewguy
Copy link
Collaborator Author

Superseded by #63

@thenewguy thenewguy closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants