Skip to content

Fix issue 65 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2019
Merged

Fix issue 65 #67

merged 5 commits into from
Nov 28, 2019

Conversation

thenewguy
Copy link
Collaborator

fixes #65

@thenewguy thenewguy mentioned this pull request Nov 11, 2019
Closed
@thenewguy
Copy link
Collaborator Author

@zerolab Were you able to take a look at this? This implementation is fairly short and sweet and should cover all cases

@thenewguy thenewguy mentioned this pull request Nov 21, 2019
Closed
zerolab
zerolab approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @thenewguy

@zerolab zerolab merged commit 54c1eb8 into torchbox:master Nov 28, 2019
@zerolab
Copy link
Member

zerolab commented Nov 28, 2019

Thank you @thenewguy. Sorry for the delay. I did not realise I had merge powers!

@thenewguy thenewguy mentioned this pull request Nov 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerolab zerolab zerolab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support media renditions
2 participants
@thenewguy @zerolab