Skip to content

Remove an incorrect UUID unit test #8554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2025
Merged

Remove an incorrect UUID unit test #8554

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51ecd7a
Remove an incorrect UUID unit test
akuzm Aug 28, 2025
7bdf50a
remove more
akuzm Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions tsl/test/src/compression_unit_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1393,19 +1393,9 @@ test_uuid_dictionary_simple()
Datum compressed = (Datum) compressor->finish(compressor);
TestAssertTrue(DatumGetPointer(compressed) != NULL);

/* Test unaligned access to satisfy code coverage */
size_t compressed_size = VARSIZE_ANY(compressed);
char *unaligned_ptr = ((char *) palloc0(compressed_size + 3)) + 3;
memcpy(unaligned_ptr, DatumGetPointer(compressed), compressed_size);

ArrowArray *bulk_result = tsl_dictionary_decompress_all(PointerGetDatum(unaligned_ptr),
UUIDOID,
CurrentMemoryContext);
const pg_uuid_t *bulk_data = (pg_uuid_t *) bulk_result->buffers[1];

ArrowArray *bulk_result2 =
ArrowArray *bulk_result =
tsl_dictionary_decompress_all(compressed, UUIDOID, CurrentMemoryContext);
const pg_uuid_t *bulk_data2 = (pg_uuid_t *) bulk_result2->buffers[1];
const pg_uuid_t *bulk_data = (pg_uuid_t *) bulk_result->buffers[1];

const CompressedDataHeader *header = (CompressedDataHeader *) PG_DETOAST_DATUM(compressed);
/* The dictionary compression may recompress the data id Array compression would save space.
Expand All @@ -1423,8 +1413,6 @@ test_uuid_dictionary_simple()
TestAssertTrue(DatumGetBool(DirectFunctionCall2(uuid_eq, r.val, uuids[i / 4])));
TestAssertTrue(DatumGetBool(
DirectFunctionCall2(uuid_eq, PointerGetDatum(&bulk_data[i]), uuids[i / 4])));
TestAssertTrue(DatumGetBool(
DirectFunctionCall2(uuid_eq, PointerGetDatum(&bulk_data2[i]), uuids[i / 4])));
}
}

Expand Down
Loading