Skip to content

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Aug 28, 2025

4-byte varlena header cannot be unaligned in Postgres. This fixes a sanitizer failure on main. Couldn't reproduce the failure itself locally though.

https://github.com/timescale/timescaledb/actions/runs/17272826513/job/49021912296#step:15:226

4-byte varlena header cannot be unaligned in Postgres. This fixes a
sanitizer failure on main. Couldn't reproduce the failure itself locally
though.
Copy link

@mkindahl, @antekresic: please review this pull request.

Powered by pull-review

@akuzm akuzm enabled auto-merge (squash) August 28, 2025 11:32
@akuzm akuzm disabled auto-merge August 28, 2025 11:32
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.45%. Comparing base (a803e5d) to head (7bdf50a).
⚠️ Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8554      +/-   ##
==========================================
+ Coverage   82.39%   82.45%   +0.05%     
==========================================
  Files         248      248              
  Lines       47609    47569      -40     
  Branches    12093    12085       -8     
==========================================
- Hits        39229    39224       -5     
- Misses       3492     3509      +17     
+ Partials     4888     4836      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akuzm akuzm enabled auto-merge (squash) August 28, 2025 13:25
@akuzm
Copy link
Member Author

akuzm commented Aug 28, 2025

There are still some failures in the sanitizer tests, but these are not sanitizer failures, just a query plan change.

@akuzm akuzm merged commit 7d10797 into timescale:main Aug 28, 2025
45 of 49 checks passed
@akuzm akuzm deleted the sanitizer branch August 28, 2025 13:26
@akuzm
Copy link
Member Author

akuzm commented Aug 28, 2025

There are still some failures in the sanitizer tests, but these are not sanitizer failures, just a query plan change.

This is due to a known problem with older pg versions, I'll add it to the ignore list: #8557

@akuzm akuzm added the force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" label Sep 15, 2025
timescale-automation pushed a commit that referenced this pull request Sep 15, 2025
4-byte varlena header cannot be unaligned in Postgres. This fixes a
sanitizer failure on main. Couldn't reproduce the failure itself locally
though.

(cherry picked from commit 7d10797)
timescale-automation pushed a commit that referenced this pull request Sep 15, 2025
4-byte varlena header cannot be unaligned in Postgres. This fixes a
sanitizer failure on main. Couldn't reproduce the failure itself locally
though.

(cherry picked from commit 7d10797)
@natalya-aksman natalya-aksman mentioned this pull request Sep 29, 2025
@timescale-automation timescale-automation added the released-2.22.1 Released in 2.22.1 label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-2.22.x force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" released-2.22.1 Released in 2.22.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants