-
Notifications
You must be signed in to change notification settings - Fork 972
Log only if compression ratio warnings enabled #8145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
64d8435
to
28c173a
Compare
28c173a
to
5640beb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8145 +/- ##
==========================================
+ Coverage 82.26% 82.34% +0.08%
==========================================
Files 255 255
Lines 47723 47696 -27
Branches 12030 12027 -3
==========================================
+ Hits 39260 39276 +16
- Misses 3647 3661 +14
+ Partials 4816 4759 -57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Probably should get changelog entry |
5640beb
to
f2cba8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we had the DEBUG1 in the first place, but this looks fine since the warning can be disabled with a GUC.
No need for logging at DEBUG1 level. Only log if the feature is enabled and compression ratio is under the threshold.
f2cba8c
to
0ba2d9a
Compare
No need for logging at DEBUG1 level. Only
log if the feature is enabled and compression
ratio is under the threshold.