Skip to content

Conversation

antekresic
Copy link
Member

@antekresic antekresic commented May 16, 2025

No need for logging at DEBUG1 level. Only
log if the feature is enabled and compression
ratio is under the threshold.

@antekresic antekresic self-assigned this May 16, 2025
@antekresic antekresic requested a review from svenklemm May 16, 2025 08:54
@antekresic antekresic added this to the v2.20.1 milestone May 16, 2025
@antekresic antekresic force-pushed the antekresic/fix_compression_warning branch from 64d8435 to 28c173a Compare May 16, 2025 08:56
@antekresic antekresic force-pushed the antekresic/fix_compression_warning branch from 28c173a to 5640beb Compare May 16, 2025 08:59
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.34%. Comparing base (46dcc64) to head (0ba2d9a).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/compression/api.c 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8145      +/-   ##
==========================================
+ Coverage   82.26%   82.34%   +0.08%     
==========================================
  Files         255      255              
  Lines       47723    47696      -27     
  Branches    12030    12027       -3     
==========================================
+ Hits        39260    39276      +16     
- Misses       3647     3661      +14     
+ Partials     4816     4759      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@antekresic antekresic marked this pull request as ready for review May 16, 2025 09:21
@antekresic antekresic enabled auto-merge (rebase) May 16, 2025 10:43
@svenklemm
Copy link
Member

Probably should get changelog entry

@antekresic antekresic force-pushed the antekresic/fix_compression_warning branch from 5640beb to f2cba8c Compare May 19, 2025 09:16
Copy link
Member

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we had the DEBUG1 in the first place, but this looks fine since the warning can be disabled with a GUC.

No need for logging at DEBUG1 level. Only
log if the feature is enabled and compression
ratio is under the threshold.
@antekresic antekresic force-pushed the antekresic/fix_compression_warning branch from f2cba8c to 0ba2d9a Compare May 20, 2025 08:59
@antekresic antekresic merged commit 954278d into main May 20, 2025
39 of 40 checks passed
@antekresic antekresic deleted the antekresic/fix_compression_warning branch May 20, 2025 09:30
@antekresic antekresic added the force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" label May 21, 2025
@philkra philkra mentioned this pull request May 27, 2025
@timescale-automation timescale-automation added the released-2.20.1 Released in 2.20.1 label Jun 2, 2025
@timescale-automation timescale-automation added the released-2.21.0 Released in 2.21.0 label Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-2.20.x force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" released-2.20.1 Released in 2.20.1 released-2.21.0 Released in 2.21.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants