Skip to content

Commit 0ba2d9a

Browse files
committed
Log only if compression ratio warnings enabled
No need for logging at DEBUG1 level. Only log if the feature is enabled and compression ratio is under the threshold.
1 parent 46dcc64 commit 0ba2d9a

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

.unreleased/pr_8145

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Implements: #8145 Log only if compression ratio warnings are enabled

tsl/src/compression/api.c

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -544,22 +544,21 @@ compress_chunk_impl(Oid hypertable_relid, Oid chunk_relid)
544544
/* Detect and emit warning if poor compression ratio is found */
545545
float compression_ratio = ((float) before_size.total_size / after_size.total_size);
546546
float POOR_COMPRESSION_THRESHOLD = 1.0;
547-
ereport(ts_guc_enable_compression_ratio_warnings &&
548-
compression_ratio < POOR_COMPRESSION_THRESHOLD ?
549-
WARNING :
550-
DEBUG1,
551-
errcode(ERRCODE_WARNING),
552-
errmsg("poor compression rate detected for chunk \"%s\"'",
553-
get_rel_name(chunk_relid)),
554-
errdetail("Chunk \"%s\" has a poor compression ratio: %.2f. Size before "
555-
"compression: " INT64_FORMAT
556-
" bytes. Size after compression: " INT64_FORMAT " bytes",
557-
get_rel_name(chunk_relid),
558-
compression_ratio,
559-
before_size.total_size,
560-
after_size.total_size),
561-
errhint("Changing compression settings for \"%s\" can improve compression rate",
562-
get_rel_name(hypertable_relid)));
547+
if (ts_guc_enable_compression_ratio_warnings &&
548+
compression_ratio < POOR_COMPRESSION_THRESHOLD)
549+
ereport(WARNING,
550+
errcode(ERRCODE_WARNING),
551+
errmsg("poor compression rate detected for chunk \"%s\"'",
552+
get_rel_name(chunk_relid)),
553+
errdetail("Chunk \"%s\" has a poor compression ratio: %.2f. Size before "
554+
"compression: " INT64_FORMAT
555+
" bytes. Size after compression: " INT64_FORMAT " bytes",
556+
get_rel_name(chunk_relid),
557+
compression_ratio,
558+
before_size.total_size,
559+
after_size.total_size),
560+
errhint("Changing compression settings for \"%s\" can improve compression rate",
561+
get_rel_name(hypertable_relid)));
563562
}
564563
else
565564
{

0 commit comments

Comments
 (0)