This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Do not log gRPC NotFound and Canceled status code #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajkumar
approved these changes
Sep 14, 2022
alejandrodnm
force-pushed
the
adn/grpc-error-log
branch
3 times, most recently
from
9ade36b to
c04d236
Compare
alejandrodnm
changed the title
alejandrodnm
force-pushed
the
adn/grpc-error-log
branch
from
c04d236 to
b1dc14f
Compare
alejandrodnm
force-pushed
the
adn/grpc-error-log
branch
from
b1dc14f to
4e5079f
Compare
- NotFound is returned, for example, when querying a Trace and the trace is not found. - Canceled when the context is canceled. Before we were checking the errors for context.Canceled but gRPC doesn't wrap the errors, it just creates an Status object that contains the error message.
alejandrodnm
force-pushed
the
adn/grpc-error-log
branch
from
4e5079f to
692113e
Compare
arajkumar
approved these changes
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we were checking the errors for context.Canceled but gRPC doesn't wrap the errors, it just creates an Status object that contains the error message.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: