Do not log gRPC NotFound and Cancelled status code

Author: alejandrodnm

CHANGELOG.md

@@ -23,6 +23,7 @@ We use the following categories for changes:
 ### Fixed
 - Fix broken cache eviction in clockcache [#1603]
 - Possible goroutine leak due to unbuffered channel in select block [#1604]
+- Stop logging as an error grpc NotFound and Canceled status codes [#1645]
 
 ## [0.14.0] - 2022-08-30
 

pkg/jaeger/store/store.go

@@ -8,6 +8,7 @@ import (
 	"context"
 	"time"
 
+	"github.com/pkg/errors"
 	"github.com/prometheus/client_golang/prometheus"
 
 	"github.com/jaegertracing/jaeger/model"
@@ -76,9 +77,14 @@ func (p *Store) GetTrace(ctx context.Context, traceID model.TraceID) (*model.Tra
 		metrics.QueryDuration.With(prometheus.Labels{"type": "trace", "handler": "Get_Trace", "code": code}).Observe(time.Since(start).Seconds())
 	}()
 	res, err := getTrace(ctx, p.builder, p.conn, traceID)
+
 	if err != nil {
-		return nil, logError(err)
+		if !errors.Is(err, spanstore.ErrTraceNotFound) {
+			_ = logError(err)
+		}
+		return nil, err
 	}
+
 	code = "2xx"
 	traceRequestsExec.Add(1)
 	return res, nil

pkg/runner/runner.go

@@ -23,7 +23,9 @@ import (
 	"go.opentelemetry.io/collector/pdata/ptrace/ptraceotlp"
 	"go.opentelemetry.io/otel"
 	"google.golang.org/grpc"
+	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/credentials"
+	"google.golang.org/grpc/status"
 
 	"github.com/google/uuid"
 	grpc_prometheus "github.com/grpc-ecosystem/go-grpc-prometheus"
@@ -66,9 +68,16 @@ func loggingUnaryInterceptor(ctx context.Context, req interface{}, info *grpc.Un
 
 func loggingStreamInterceptor(srv interface{}, ss grpc.ServerStream, info *grpc.StreamServerInfo, handler grpc.StreamHandler) error {
 	err := handler(srv, ss)
-	if err != nil && !errors.Is(err, context.Canceled) {
-		log.Error("msg", "error in GRPC call", "err", err)
+	if err == nil {
+		return nil
 	}
+
+	st, ok := status.FromError(err)
+	if ok && (st.Code() == codes.NotFound || st.Code() == codes.Canceled) {
+		return err
+	}
+
+	log.Error("msg", "error in GRPC call", "err", err)
 	return err
 }