-
Notifications
You must be signed in to change notification settings - Fork 10
feat(base-cluster/traefik): Changed ipFamilyPolicy to DualStack #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User Values (.Values)
participant H as Helm Template
participant K as Kubernetes Service (Traefik)
U->>H: Provide ingress.IP
alt .Values.ingress.IP is set
H->>K: Render Service with\n`loadBalancerIP` and\n`ipFamilyPolicy: PreferDualStack`
note right of K #D6EAF8: Dual-stack preference enabled
else
H->>K: Render Service without\n`ipFamilyPolicy` set
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
charts/base-cluster/values.schema.json (1)
1429-1437
: Good addition; enum matches Kubernetes values.The property is well-scoped and consistent with ServiceSpec ipFamilyPolicy values.
If desired, consider exposing ipFamilies (array: ["IPv4","IPv6"]) alongside ipFamilyPolicy for environments that require explicit ordering.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
charts/base-cluster/templates/ingress/traefik.yaml
(1 hunks)charts/base-cluster/values.schema.json
(1 hunks)charts/base-cluster/values.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Update release-please config file for a possibly new chart
- GitHub Check: check licenses
- GitHub Check: lint helm chart (base-cluster)
🔇 Additional comments (1)
charts/base-cluster/values.yaml (1)
442-442
: Sensible default.PreferDualStack is safe on single‑stack clusters and enables dual‑stack where supported.
Please confirm this default is intended for both nginx and traefik providers, even though only the Traefik template currently consumes it.
1fa4e15
to
dd6389a
Compare
e3ae0ab
to
ad59bca
Compare
ad59bca
to
a7fdc04
Compare
🤖 I have created a release *beep* *boop* --- ## [9.4.0](base-cluster-v9.3.2...base-cluster-v9.4.0) (2025-09-25) ### Features * **base-cluster/traefik:** Changed ipFamilyPolicy to DualStack ([#1694](#1694)) ([166c9af](166c9af)) ### Bug Fixes * **base-cluster/velero:** remove last reference to bitnami images ([#1701](#1701)) ([50a5112](50a5112)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enable DualStack IP family for Traefik in the base cluster, improving IPv4/IPv6 compatibility. - Bug Fixes - Addresses issues related to Velero stability. - Documentation - Adds a changelog entry for version 9.4.0 with details on new features and fixes. - Chores - Bumps the base cluster chart to version 9.4.0 and updates the release manifest. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
ipFamilyPolicy for ipv6 Dual-Stack Ingress
https://github.com/traefik/traefik-helm-chart/blob/master/traefik/values.yaml#L825C5-L825C19
Summary by CodeRabbit
New Features
Refactor