Skip to content

Conversation

@kiview
Copy link
Member

@kiview kiview commented Apr 6, 2022

#5149 did already deprecated getContainerIpAddress, but only in the Javadoc and it missed the @Deprecated annotation. This PR is simply the follow-up.

The correct deprecation implicitly fixes #4715, since the deprecation now advocates for using the correctly defined getHost() method.

@kiview kiview requested review from bsideup and rnorth as code owners April 6, 2022 15:22
@kiview kiview added this to the next milestone Apr 6, 2022
@kiview kiview merged commit 734678f into master Apr 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the deperecate-container-ip-address branch April 7, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ContainerState#getContainerIpAddress() returns a non-IP string

3 participants