`ContainerState#getContainerIpAddress()` returns a non-IP string

[mateuszrzeszutek]

The getContainerIpAddress() method may return "localhost", which is not an IP address (it indirectly calls the DockerClientProviderStrategy#resolveDockerHostIpAddress() method, which uses "localhost" as a fallback value for a couple of cases). The javadoc says @return an IP address and doesn't mention that the method can return non-IP values at all.

Also see open-telemetry/opentelemetry-java-instrumentation#4745

[bsideup]

Hi @mateuszrzeszutek,

Thanks. We should really deprecate getContainerIpAddress() as we were providing getHost() for years for exactly the reason you described - confusing name of the original method.

Consider using getHost() everywhere, and we will mark getContainerIpAddress() as deprecated in future releases 👍

[mateuszrzeszutek]

Got it 👍
Thanks for the prompt response!