Remove unused JEE deps #2505
Merged
Remove unused JEE deps #2505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Apr 1, 2020
Co-Authored-By: Sergei Egorov <[email protected]>
Member
|
If we don't need these then presumably #2091 is not needed? That seems like it would be a good outcome to me... |
bsideup
approved these changes
Apr 12, 2020
rnorth
approved these changes
Apr 12, 2020
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
Two compile dependencies referencing JEE artifacts don't seem to be required for compilation. This PR removes them from the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two compile dependencies referencing JEE artifacts don't seem to be required for compilation. This PR removes them from the build.
Closes #2091