Skip to content

Conversation

@aguibert
Copy link
Contributor

No description provided.

@stale
Copy link

stale bot commented Feb 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Feb 27, 2020
@stale stale bot removed the stale label Feb 27, 2020
@aguibert
Copy link
Contributor Author

hi @bsideup, can you take a look at this one please? Just a simple one-liner dependency update

@bsideup
Copy link
Member

bsideup commented Mar 13, 2020

@aguibert I am not sure about this one. It is not just a one-liner but also a change to our public dependencies. Can we postpone it until Jakarta adoption reaches the majority vs javax?

@dajudge
Copy link
Member

dajudge commented Apr 1, 2020

Just adding my 2 cents here: Quarkus is actively warning when testcontainers.org is used in the project. While this probably won't have strong negative effects in most projects as testcontainers is usually only used as a test dependency, fixing this issue would remove ths warning:

These dependencies are not recommended:
        - javax.annotation:javax.annotation-api should be replaced by jakarta.annotation:jakarta.annotation-api
You might end up with two different versions of the same classes or with an artifact you shouldn't have in your classpath.

@bsideup
Copy link
Member

bsideup commented Apr 1, 2020

I wonder if we still need both. Can somebody verify it, and maybe remove them?

Also, I believe the Jakarta community should figure out first how to deal with the fact that there will be two dependencies with different GAV but same packages.
Updating to Jakarta's ones may hurt us in future with some old libraries that are not Jakarta aware (when Jakarta start evolving the APIs)

@aguibert
Copy link
Contributor Author

aguibert commented Apr 1, 2020

@bsideup both are not needed in the future -- just the jakarta dependencies.

What do you want someone to verify? This PR updates the deps and the CI results show that tests are still passing after the change

@rnorth rnorth mentioned this pull request Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants