Skip to content

Add build script to make an (svg) demo of all available themes #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add build script to make an (svg) demo of all available themes #2079

wants to merge 3 commits into from

Conversation

@ppenguin
Copy link

@ppenguin ppenguin force-pushed the generate-demo-all-themes branch from 5c66561 to 755da3d Compare April 2, 2025 19:07
@ppenguin
Copy link
Author

ppenguin commented Apr 2, 2025

@alixander I revived this while checking #2065 and integrated it better (so it's basically just one extra rule to the Makefile now)
Maybe we can integrate it like this...

BTW: in my env prefix is not found, so the Makefile doesn't work for testing. What is prefix and what does it do?

alixander
alixander requested changes Aug 2, 2025
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also apologies for the delay on this.

Instead of outputting in testdata/examples, let's put it in a new d2themes/samples directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alixander alixander alixander requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ppenguin @alixander