-
Notifications
You must be signed in to change notification settings - Fork 582
Add new dark theme: Dark berry blue #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@ppenguin Thanks for this PR! Can you screenshot what it looks like? And no the goal isn't to have a dark theme equivalent to every light theme. There's very few themes I've seen in the software world that have a light and dark version. Even then, if you saw their light and dark versions among others, it wouldn't be obvious they belong to the same theme, so they're kind of just two different themes. D2 should categorize the two separately -- mirrors of light/dark themes are fine as long as they make sense and look good, but no need to have mirrors for every theme. |
fdbc460
to
1659ebb
Compare
Makes sense, no need to go overboard, it's just that the choice of "tones" felt kind of incomplete, from gut feeling I think a few more would be nice, this one would go into the category "dark pastel blue/purple". That would make the status like this:
and possibly TODO:
This branch has a handy build script to (re)generate an example for all available themes (you can include it in the codebase if you want to). |
1659ebb
to
f4249ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you please add a line to changelog (next.md) of the new theme too (under improvements)?
@ppenguin Nice build script! I think that'd be useful as a dev tool in the d2themes package if you want to make a separate PR to help include that. The hardcoded theme value in the d2 file used should be removed though (https://github.com/ppenguin/d2/blob/ppdev/testdata/examples/themex.d2#L6). No obligation to of course, will keep this in mind and get to it myself down the road if not. |
tweak darkberry theme t
d19e3b4
to
db24121
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please forgive the delay, this looks good, would you mind doing a rebase and updating the next.md? Thank you for this.
The number of built-in dark themes is lacking compared to the light themes.
This PR aims to be a first step to alleviate this, in submitting a dark variant of "Mixed Berry Blue".
As a side note: it would be logical to make the IDs of themes a bit more symmetrical: since the ID category seems to be
200 <= DarkThemeID < 300
, it is a logical expectation that a dark variant of an existing light theme isLightID + 200
?It would be a reasonable goal to work toward "dark theme coverage" in this sense too?