entrypoint: handle linux in pkgs/platforms #9096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, we can errors such as the following
ERROR failed to get CPU variant os=linux error="getCPUVariant for OS linux: not implemented"
could not find command for platform "linux/arm64"
The main reason for this is because we are missing the variant when
getting the platform, but the oci images for arm64 have it, and thus
`TEKTON_PLATFORM_COMMANDS` as well. It creates a mismatch, and the
entrypoint cannot find the command it looks for.
Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
added
kind/bug
tekton-robot
added
the
size/XS
Member
Author
|
/cherry-pick v1.0.x |
Member
Author
|
/cherry-pick v1.3.x |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Member
|
/retest |
Member
|
Hopefully you're successful in setting up arm tests so we don't risk breaking this in future. |
Member
Author
|
@afrittoli the cherry-pick "bot" is not running in the infra anymore ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Without this, we can errors such as the following
The main reason for this is because we are missing the variant when getting the platform, but the oci images for arm64 have it, and thus
TEKTON_PLATFORM_COMMANDSas well. It creates a mismatch, and the entrypoint cannot find the command it looks for.Essentially it means that anyone running arm64 cluster and not using
scriptor specifyingcommandwon't be able to run a TaskRun 😅 .Closes #9094
/kind bug
@tektoncd/core-maintainers this will need to be cherry-pick to all LTS after 0.68.
Note: This is extracted from #9090 (which runs e2e tests on arm64 to catch things like that) so that we get it merged more quickly.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes