ci/e2e: run one e2e on arm64 #9090
Merged
+35
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/S
vdemeester
force-pushed
the
ci-try-arm64
branch
from
101bab0 to
21a52a3
Compare
tekton-robot
added
size/M
vdemeester
force-pushed
the
ci-try-arm64
branch
from
21a52a3 to
fcce3d0
Compare
tekton-robot
added
size/S
vdemeester
force-pushed
the
ci-try-arm64
branch
4 times, most recently
from
bddcfa5 to
ad6cc29
Compare
tekton-robot
added
size/L
vdemeester
force-pushed
the
ci-try-arm64
branch
6 times, most recently
from
5c76f4b to
5617757
Compare
tekton-robot
added
size/M
vdemeester
force-pushed
the
ci-try-arm64
branch
2 times, most recently
from
903dd1d to
bf847d0
Compare
8 tasks
This should be possible to do, so let's exercise our e2e tests on arm64 as well as the usual amd64. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
ci-try-arm64
branch
from
4d12a1a to
4017e7d
Compare
Member
Author
🤔 |
Member
Author
|
Member
Author
|
tektoncd/plumbing#2915 should fix that. |
vdemeester
force-pushed
the
ci-try-arm64
branch
from
5f6d981 to
04308c7
Compare
Member
Author
|
Alright the ARM64 e2e jobs is finally green 🎉 I will re-enable all e2e tests, this is now ready for review 👼🏼 |
.. and also point to the manifest list, aka a multi-arch image. Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
With this, it can't run on arm64 clusters... Signed-off-by: Vincent Demeester <[email protected]>
Not sure what they are testing, but they prevent us from running e2e tests on other architectures, and they are already covered by unit-tests and multi-arch images tests just above. Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
ci-try-arm64
branch
from
04308c7 to
fdefd36
Compare
tekton-robot
added
size/M
Member
Author
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
vdemeester
commented
Oct 27, 2025
|
|
||
| sidecars: | ||
| - image: docker@sha256:74e78208fc18da48ddf8b569abe21563730845c312130bd0f0b059746a7e10f5 | ||
| - image: docker@sha256:0752ca4e936da012c173c119217c0f9599b3b191c1557e53206d5d06d2627580 |
Member
Author
There was a problem hiding this comment.
This is the same image, but it points to the manifest list (aka multi-arch image) instead of the amd64 image.
vdemeester
commented
Oct 27, 2025
Comment on lines
-58
to
-72
| busyboxImage: "busybox@sha256:4f47c01fa91355af2865ac10fef5bf6ec9c7f42ad2321377c21e844427972977", | ||
| busyboxImage: "busybox@sha256:2f9af5cf39068ec3a9e124feceaa11910c511e23a1670dcfdff0bc16793545fb", | ||
| registryImage: "ibmcom/registry:2.6.2.5", | ||
| kanikoImage: "gcr.io/kaniko-project/executor:s390x-9ed158c1f63a059cde4fd5f8b95af51d452d9aa7", | ||
| dockerizeImage: "ibmcom/dockerize-s390x", | ||
| } | ||
| case "ppc64le": | ||
| return map[int]string{ | ||
| busyboxImage: "busybox@sha256:4f47c01fa91355af2865ac10fef5bf6ec9c7f42ad2321377c21e844427972977", | ||
| busyboxImage: "busybox@sha256:2f9af5cf39068ec3a9e124feceaa11910c511e23a1670dcfdff0bc16793545fb", | ||
| registryImage: "ppc64le/registry:2", | ||
| kanikoImage: "ibmcom/kaniko-project-executor-ppc64le:v0.17.1", | ||
| dockerizeImage: "ibmcom/dockerize-ppc64le", | ||
| } | ||
| default: | ||
| return map[int]string{ | ||
| busyboxImage: "busybox@sha256:895ab622e92e18d6b461d671081757af7dbaa3b00e3e28e12505af7817f73649", |
Member
Author
There was a problem hiding this comment.
Same here, it replaces amd64 images with multi-arch images.
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Member
|
/retest |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This should be possible to do, so let's exercise our e2e tests on arm64 as well as the usual amd64.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes