-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Remove temporary GOPATH
generation in in update-codegen.sh
and update-openapigen.sh
.
#8719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove temporary GOPATH
generation in in update-codegen.sh
and update-openapigen.sh
.
#8719
Conversation
/kind cleanup |
/test check-pr-has-kind-label |
@twoGiants: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Once rebased, it can be merged
/lgtm
Remove temporary GOPATH directory generation for codegen and openapigen. The project uses Go modules but the code generation script executed by `make generated` uses a legacy workflow creating a temporary GOPATH directory and downloading all dependencies needed for code generation on every run. This takes 15 - 20 min for every execution. Removing `setup-temporary-gopath.sh` and its references falls back to using Go modules and `make generated` executes under 2 min. Signed-off-by: Stanislav Jakuschevskij <[email protected]>
a8d4f8b
to
b94091c
Compare
@afrittoli I rebased the branch. I updated the PR message. Now that Vincents Go update was made and the code generation scripts were updated the change is not as significant but still an improvement. See my message above. Thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
Note
Since the merge of #8482 the code generation in the main branch is faster, 6min 45s but still downloads a lot of packages every time. With this PR the downloads will be reduced but not eliminated, it will run in 4min. The run time depends on your connection.
Changes
Remove temporary
GOPATH
directory generation inupdate-codegen.sh
andupdate-openapigen.sh
.The project uses Go modules but the code generation script executed by
make generated
uses a legacy workflow creating a temporaryGOPATH
directory and downloading all dependencies needed for code generation on every run. This takes 15-20 min for every execution.Removing
setup-temporary-gopath.sh
and its references falls back to using Go modules andmake generated
executes under 2 min.Closes #8718.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes