Bump go.mod and tools/go.mod to go 1.23 #8482

vdemeester · 2025-01-13T18:13:09Z

Changes

Some dependencies will depend on 1.23, and the test-runner
image already is up-to-date, so let's use it.

Signed-off-by: Vincent Demeester [email protected]

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
pre-commit Passed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Updating go to 1.23

vdemeester · 2025-01-24T13:20:02Z

.github/workflows/e2e-matrix.yml

-      uses: actions/checkout@v4
+      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
      with:
        path: ${{ github.workspace }}/src/github.com/tektoncd/pipeline


@afrittoli any reason to checkout into GOPATH ? It shouldn't be needed nowadays (GOPATH I mean)

ko does not work otherwise, last I tried. It may be different now.

@afrittoli you mean ko on the github worklows ? Because it definitely works locally for me.

Yes, but I didn't really try too hard to make it work, it just worked when checking out that way, so I kept it.
If you'd like to change it, it's perfectly fine by me, I don't have a preference 🙏

waveywaves · 2025-01-24T16:22:13Z

/test pull-tekton-pipeline-build-tests

waveywaves · 2025-01-27T11:11:02Z

@vdemeester the build tests are failing

 F0124 16:24:35.770703   13678 deepcopy.go:894] Hit an unsupported type github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1.PipelineResourceType for github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1.PipelineResourceType, from github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1.PipelineResourceSpec 
 ``

vdemeester · 2025-02-18T09:02:45Z

/test pull-tekton-pipeline-build-tests

tekton-robot · 2025-02-18T10:51:17Z

@vdemeester: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-pipeline-build-tests	`cd5e028`	link	true	`/test pull-tekton-pipeline-build-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vdemeester · 2025-02-18T10:55:49Z

/hold
probably need some things from #8538

vdemeester · 2025-03-03T14:12:07Z

/hold cancel

waveywaves · 2025-03-03T14:42:35Z

/assign

Signed-off-by: Vincent Demeester <[email protected]>

vdemeester · 2025-04-23T10:54:18Z

Hum, now I am getting

The CustomResourceDefinition "taskruns.tekton.dev" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

cc @burigolucas

tekton-robot · 2025-04-25T13:53:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/runner.go	86.2%	81.0%	-5.2

This is to ensure we are up-to-date with code-generation and go 1.23. This also rework some codegen… Signed-off-by: Vincent Demeester <[email protected]>

vdemeester · 2025-04-25T13:57:49Z

/hold cancel

waveywaves · 2025-04-25T14:27:59Z

/lgtm

abayer · 2025-04-25T15:21:48Z

/approve

tekton-robot · 2025-04-25T15:21:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [abayer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jan 13, 2025

tekton-robot requested review from afrittoli and pritidesai January 13, 2025 18:13

tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 13, 2025

vdemeester force-pushed the bump-to-go-1.23 branch from efcef55 to 6d551d1 Compare January 14, 2025 11:50

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2025

vdemeester force-pushed the bump-to-go-1.23 branch from 6d551d1 to aa144d5 Compare January 24, 2025 13:19

tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2025

vdemeester commented Jan 24, 2025

View reviewed changes

vdemeester force-pushed the bump-to-go-1.23 branch from aa144d5 to 05aadf2 Compare February 18, 2025 08:33

vdemeester mentioned this pull request Feb 18, 2025

build(deps): bump github.com/spiffe/go-spiffe/v2 from 2.4.0 to 2.5.0 #8551

Merged

vdemeester force-pushed the bump-to-go-1.23 branch from 05aadf2 to cd5e028 Compare February 18, 2025 10:46

tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 18, 2025

vdemeester force-pushed the bump-to-go-1.23 branch from cd5e028 to 482b823 Compare March 3, 2025 14:11

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2025

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2025

vdemeester force-pushed the bump-to-go-1.23 branch from 482b823 to 0574661 Compare March 3, 2025 14:23

tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 3, 2025

.github/workflows: update setup-go to use go.mod version

e779ba5

Signed-off-by: Vincent Demeester <[email protected]>

vdemeester force-pushed the bump-to-go-1.23 branch from cf1c309 to e8712d3 Compare April 22, 2025 23:02

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2025

vdemeester force-pushed the bump-to-go-1.23 branch 2 times, most recently from 7717085 to a52c059 Compare April 23, 2025 00:14

tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 23, 2025

vdemeester added this to the Pipeline v1.0.0 milestone Apr 25, 2025

vdemeester force-pushed the bump-to-go-1.23 branch 4 times, most recently from d8a18c5 to 6017ebc Compare April 25, 2025 13:43

vdemeester and others added 2 commits April 25, 2025 15:55

Updating knative/pkg and k8s.io libraries…

77186d2

This is to ensure we are up-to-date with code-generation and go 1.23. This also rework some codegen… Signed-off-by: Vincent Demeester <[email protected]>

Remove schema for PodSecurityContext

d82a755

vdemeester force-pushed the bump-to-go-1.23 branch from 6017ebc to d82a755 Compare April 25, 2025 13:56

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2025

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2025

waveywaves approved these changes Apr 25, 2025

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025

tekton-robot merged commit ea94e3a into tektoncd:main Apr 25, 2025
20 checks passed

github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Apr 25, 2025

vdemeester deleted the bump-to-go-1.23 branch April 25, 2025 16:34

twoGiants mentioned this pull request Apr 30, 2025

Remove temporary GOPATH generation in in update-codegen.sh and update-openapigen.sh. #8719

Merged

8 tasks

vdemeester mentioned this pull request May 13, 2025

CODEGEN | unsupported type entry warnings when running ./hack/update-codegen.sh tektoncd/operator#2720

Closed

Bump go.mod and tools/go.mod to go 1.23 #8482

Bump go.mod and tools/go.mod to go 1.23 #8482

Uh oh!

Conversation

vdemeester commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

vdemeester Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

afrittoli Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

vdemeester Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

afrittoli Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

waveywaves commented Jan 24, 2025

Uh oh!

waveywaves commented Jan 27, 2025

Uh oh!

vdemeester commented Feb 18, 2025

Uh oh!

tekton-robot commented Feb 18, 2025

Uh oh!

vdemeester commented Feb 18, 2025

Uh oh!

vdemeester commented Mar 3, 2025

Uh oh!

waveywaves commented Mar 3, 2025

Uh oh!

vdemeester commented Apr 23, 2025

Uh oh!

tekton-robot commented Apr 25, 2025

Uh oh!

vdemeester commented Apr 25, 2025

Uh oh!

waveywaves commented Apr 25, 2025

Uh oh!

abayer commented Apr 25, 2025

Uh oh!

tekton-robot commented Apr 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vdemeester commented Jan 13, 2025 •

edited

Loading

afrittoli Jan 24, 2025 •

edited

Loading