Sync with upstream #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Closes #8991 Differential Revision: D3612777 Pulled By: dmmiller fbshipit-source-id: d8da5ef8354cdaf55d8a3efbc2bfbc2aef74a044
Summary: revision of #5476 It has only one method `shareTextContent` and next will be`shareBinaryContent`. In Android, Promise can't receive a result, because `startActivityForResult` is not working with `Intent.ACTION_SEND`. Maybe we can use `createChooser(Intent target, CharSequence title, IntentSender sender)` which requires API level 22. Closes #5904 Differential Revision: D3612889 fbshipit-source-id: 0e7aaf34b076a99089cc76bd649e6da067d9a760
Reviewed By: majak Differential Revision: D3610634 fbshipit-source-id: 1dc9017c0a34ced231b5bebe334591f3d0b89bf3
Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: > **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.** (You can skip this if you're fixing a typo or adding an app to the Showcase.) Explain the **motivation** for making this change. What existing problem does the pull request solve? I'm new to React-Native and noticed a broken link in the documentation. It's just a quick fix. Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Mat Closes #8982 Differential Revision: D3612982 fbshipit-source-id: 2996730e51ae7a243697f305cd2ed2eb0d2985a8
Summary:
`./scripts/run-android-local-unit-tests.sh` raise error
```
05: error: cannot access com.facebook.react.bridge.CatalystInstance
verify(mCatalystInstanceImpl).loadScriptFromOptimizedBundle(
^
class file for com.facebook.react.bridge.CatalystInstance not found
```
and this PR fix it.
Closes #8957
Differential Revision: D3613491
Pulled By: bestander
fbshipit-source-id: 53b52fca13482e6474d7ffec9c19c0e7d6e4d100
Summary: The links was a mix of W3Schools, CSS-Tricks and MDN. Everything is now a MDN link now. [Why?](http://www.w3fools.com/) Closes #9005 Differential Revision: D3613520 fbshipit-source-id: 86585613a822a9027f42b61ac5d0abb7c351fa80
Summary: Hi folks ! 🔧 Fix the navigation card stack pan responder when the `vertical` direction is enabled. **Issue:** When using a `ScrollView` with the `vertical` direction enabled, the pan handler catch the gesture before the `ScrollView`. I don't know why there was no default value here for `RESPOND_POSITION_MAX_VERTICAL` 5162eb3 ericvicenti could you tell me what you think about setting a default value for `RESPOND_POSITION_MAX_VERTICAL` ? 😃 Thanks !! **EDIT June 15, 2016** I'll update this PR this week end to provide a way to give custom values as there is no magic value for `RESPOND_POSITION_MAX_VERTICAL` **EDIT June 24, 2016** I've added a props `gestureResponseDistance` to control both the `RESPOND_POSITION_MAX_VERTICAL` and `RESPOND_POSITION_MAX_HORIZONTAL` Closes #8076 Differential Revision: D3605973 Pulled By: ericvicenti fbshipit-source-id: 158d88cf8ebbab742bf0b38c217ae502e9dd1963
Reviewed By: mhorowitz Differential Revision: D3507905 fbshipit-source-id: cbe55495a991bf6eef961319ba8b219e660dce05
Summary: lineBreakMode only in rc so I think we can replace property without any deprecation warnings. satya164 Closes #9008 Differential Revision: D3614901 fbshipit-source-id: 724227c0a89192825a24850b930b80884571a51f
Reviewed By: cpojer Differential Revision: D3619143 fbshipit-source-id: e14e81468d467437ee3d79c34c34b7780a46ca1c
Summary: This shows at max 5 progress updates per second on the terminal, which results in a minor speedup of reloads. Reviewed By: bestander Differential Revision: D3620164 fbshipit-source-id: d1a30f2f29f7088602d276b8ad3fc8ff1b74c79d
Reviewed By: bnham Differential Revision: D3598103 fbshipit-source-id: 3bd7069379cd38bd86c13a87487f546044f66902
Summary: Updated the keyboard input element on the browser debugger page that contains "⌘⌥J" from a `span` to the more semantic `kbd`. Closes #8998 Differential Revision: D3620668 fbshipit-source-id: ab3081688202c85978f6f400a42eb1aa1abb77c6
Summary: RN imports CSSLayout files like so: `#import <CSSLayout/CSSLayout.h>`, so we need to tell CocoaPods to preserve the directory structure for CSSLayout files. This is done with the header_mappings_dir, but we want it to apply just to CSSLayout's files, hence the subspec. Closes #9015 Differential Revision: D3621727 fbshipit-source-id: fb3603a0820ca3d6502813204ff215cf160b1955
Summary: Change the textalign setter to support RTL. In order to support text alignment according to layout style, move the textalign setter bridge function from ReactTextViewManager.java to ReactTextShadowNode.java and calculate it correctly on RCTTextUpdate. Reviewed By: dmmiller Differential Revision: D3597494 fbshipit-source-id: e5ca17b99b4233cc49a447a34175473e339ff53d
Summary: Provide two function in I18nUtil to get the device and app current using language. And Set isRTL with both allowRTL and current app using language. Reviewed By: fkgozali Differential Revision: D3603412 fbshipit-source-id: 6bb280d56af9a12901148df9fab368366073680f
Summary: Closes #9033 Differential Revision: D3626602 fbshipit-source-id: 2a452fb36910f960e992d32bda58c40dad309b6a
Summary: [Jest 14.0](http://facebook.github.io/jest/blog/2016/07/27/jest-14.html) is out and compatibility with react-native has greatly improved. Let's update the docs to reflect this :) Closes #9041 Differential Revision: D3627580 Pulled By: davidaurelio fbshipit-source-id: 427c424b55e6bf14ebb8c2a119a92d13d79a532e
Summary: A tiny PR to add support for launching IDEA editors with the cursor at the correct line. The argument syntax is the same as sublime. The base names `wstorm`, `idea` and `appcode` are the default names when CLI launchers are created through 'Tools'->'Create Command-Line launcher' in the respective editor's gui. Tested through a fork of RN on Webstorm, IntelliJ and AppCode for OSX and by manual invocation from CLI on IntelliJ for windows. Closes #9042 Differential Revision: D3627680 fbshipit-source-id: dfb0db92f9ca8b464471c3dc9e92196d87d2e244
Summary: There is a conflict between RCTImageLoader and RCTAssetsLibraryRequestHandler on handling images, which was caused by making RCTPhotoLibraryImageLoader able to handle assets library requests as well. This gives more priority to RCTImageLoader instead. Fixes #9031. Reviewed By: mmmulani Differential Revision: D3627451 fbshipit-source-id: 7ffd2c66f43ce1479c9a117768fb2d29f9d0dc08
Summary: Use UNSET(-1) as default will lead wrong calculation for text alignment. Change it to Gravity.NO_GRAVITY to fix this problem. Reviewed By: fkgozali Differential Revision: D3624417 fbshipit-source-id: c116560e64600be60b2fe719f575701b00f20a97
Summary: The link to `'ShadowPropTypesIOS'` in `View` and `Image` docs is broken since RN0.29 Closes #8814 Differential Revision: D3628978 Pulled By: lacker fbshipit-source-id: b233e191d1e1e0731cd5b2fe33287d68aa12e041
…ion in inspector tool Summary: This diff - creates `XHRInterceptor` to intercept all XMLHttpRequest network operations in React Native by monkey-patching. - enables `XHRInterceptor` in RN development tool "inspector". This interception and inspector tool work well on both Android and iOS. And this supports interception on any network API based on XMLHttpRequest, especially the Fetch API. By now, we can intercept 12 information fields of a XMLHttpRequest including method, url, data sent, status, response type, response size, requestHeaders, responseHeaders, response, responseURL, responseType and timeout. Follow-up: - Will add UIs in the inspector on top of this diff, to display all the network operation information. (Not in this diff just to make this shorter) - Will extend this to gather other valuable information towards one XMLHttpRequest. - Should support other network request APIs like WebSocket. Reviewed By: davidaurelio Differential Revision: D3598873 fbshipit-source-id: 3221050ab2ebd876a718fc326646c344d0944a5f
Summary: This diff adds a UI to display network information flows in the inspector tool (Android and iOS both supported): - uses a ListView to show network flows, always scrolling to the latest item when a new network request occurs. - displays the network requests as soon as they were created. - highlights the selection row and toggles events to log the detailed intercepted information. (Next diff will draw UIs for this). Follow-up: - Will add one detail view to show all valuable information about a network request, after user clicks on one item in the ListView. - Add more tabs in the detail view, ideally looking like the chrome network panel. Reviewed By: davidaurelio Differential Revision: D3598900 fbshipit-source-id: 5ec9ade6d13e3a9110db105fafbc7ba52adc515d
Summary: This diff adds a detail view for the network inspector. When pressing one item in the network flow list, a popup scrollView with detailed information about the network request will be shown. More interesting, the detail information is shown in real time, which means the detail information will be updated dynamically as soon as the network request is updated (maybe receiving a response after waiting). Also have made sure this works on both Android and iOS. Reviewed By: davidaurelio Differential Revision: D3627566 fbshipit-source-id: e868d0c0287d392018b9fa64fce53b4c4b3d76d9
Reviewed By: jingc Differential Revision: D3632310 fbshipit-source-id: e6ccbfaaccf6853c615956842ea657eaba76cbe2
Summary: Supersedes PR #8536 Fixes #5211 JavaScript plugins such as Fotorama are broken when attempting use its fullscreen feature. If there's an absolute HTML element with 100% height under <body>, its height is 0 when rendered in the Android WebView. This commit fixes it. Closes #8830 Reviewed By: bestander Differential Revision: D3632821 Pulled By: jamesgpearce fbshipit-source-id: c185bcd30d1d214a357d0d8552d61d0ddfa5e6c6
Summary: Q: Explain the **motivation** for making this change. What existing problem does the pull request solve? A: There is no example for [`SwipeableListView`](https://github.com/facebook/react-native/tree/master/Libraries/Experimental/SwipeableRow) component, it would be helpful to add one. **Test plan (required)** Some screenshots here: <img width="377" alt="screen shot 2016-07-14 at 21 47 50" src="https://cloud.githubusercontent.com/assets/1091472/16841629/af8392c4-4a0c-11e6-9f92-208aba514f36.png"> Tested on: 1. Simulators iPhone 4s, 5, 5s, 6, 6 Plus Closes #8782 Differential Revision: D3624365 fbshipit-source-id: 76598ac69bca1dca6ae928d2d19c9f1384d8e161
Reviewed By: kassens Differential Revision: D3627753 fbshipit-source-id: 35b8246c8cb61e60908d8c233a6e72063bf67096
Reviewed By: donyu Differential Revision: D3581390 fbshipit-source-id: 869437dd05db614f8191eab69723c4742df0637b
Reviewed By: astreet Differential Revision: D3334273 fbshipit-source-id: a33bf72c5c184844885ef3ef610a05d9c102c8ea
Summary: …an the font size (per CSS spec) Extending upon work #7603 Closes #8851   Closes #9211 Differential Revision: D3706347 fbshipit-source-id: 0adfff8e8418b02f9b5d6671f5c89669e41abec3
Summary: Adds support for `Animated.Value#addListener` for native driven animated values. Same as #8844 but for iOS. This depends on some JS code in #8844 so only review the 2nd commit and let's wait for #8844 to land first. **Test plan** Tested using the UIExplorer example. Closes #9194 Differential Revision: D3681749 fbshipit-source-id: 521a61e2221c1ad1f6f40c75dd2dc957361d0271
Reviewed By: michalgr Differential Revision: D3703392 fbshipit-source-id: 670185de1eefd1c542de2df96e40aede3b2c12cc
Reviewed By: IanChilds Differential Revision: D3709071 fbshipit-source-id: 421d75924ecc12d6d0975e342f3862cf5592f65f
Reviewed By: vjeux Differential Revision: D3703300 fbshipit-source-id: ad03d558d6af61aba17899ec256d71fdda4c4c84
Summary: We have a weak build machine for React Native app: a poor Mac Book Air with HDD, which is very slow. So, fs operations sometimes fail because of timeout. We likely don't care about build time, but it's pretty annoying to restart builds sometimes. In this PR I make timeout injectable via environment variable. __USAGE__: export this variable into environment. It's measured in miliseconds. Example, for 1 minute timeout: `export REACT_NATIVE_FSOP_TIMEOUT=60000` If you don't specify it, it will remain default value: `15000` This should not break anything, but repair slow builds. Related to : #9373 , #8794 (I think so) This PR should handle case of issue and close #9373 Closes #9374 Differential Revision: D3709325 Pulled By: bestander fbshipit-source-id: b00c89e10d05362314546faea7a4524f3d327c97
Summary: This is a very hacky solution to make reloads from packager faster for simple file changes. Simple means that no dependencies have changed, otherwise packager will abort the attempt to update and fall back to the usual rebuilding method. In principle, this change avoids re-walking and analyzing the whole dependency tree, and just updates modules in existing bundles. Reviewed By: bestander Differential Revision: D3703896 fbshipit-source-id: 671206618dc093965822aed7161e3a99db69a529
…nfig.js` Summary: Currently we just try to resolve a rn-cli.config.js file by walking up the tree from node_modules/react-native. In non-standard uses of RN, when your copy of RN may not live within node_modules, it's impossible to use rn-cli.config.js. This PR adds a "config" flag to the cli that let's you pass in a path to rn-cli.config.js. cc ide Closes #7883 Differential Revision: D3382823 Pulled By: bestander fbshipit-source-id: b946f3bb355050fc2fe99273d0e99e441dbed111
Reviewed By: astreet Differential Revision: D3334273 fbshipit-source-id: a3849604ea89db74900850c294685e7da9aeeacc
Summary: This dependency on okhttp is unused. Removing this to lower the method-count increase from including the core RN modules. Reviewed By: AaaChiuuu Differential Revision: D3711870 fbshipit-source-id: 54b92edb4a55140b33cc74a5e9270650ced56ab9
Summary: This is a very hacky solution to make reloads from packager faster for simple file changes. Simple means that no dependencies have changed, otherwise packager will abort the attempt to update and fall back to the usual rebuilding method. In principle, this change avoids re-walking and analyzing the whole dependency tree, and just updates modules in existing bundles. Reviewed By: bestander Differential Revision: D3703896 fbshipit-source-id: abc2a41144536baf969d346522a17044c1c9558b
…ne cleanup Summary: We only want to call onTransitionEnd after the transition has fully completed, including scene cleanup. This will help avoid race conditions when we start new navigation after a transition completes. Reviewed By: fkgozali Differential Revision: D3712235 fbshipit-source-id: 146f30a0caf3d2fe164285fbef12293b7b161c6e
Reviewed By: tadeuzagallo Differential Revision: D3703415 fbshipit-source-id: c67865b7fe75c21a3b620dc3a794b5a0005cf71e
Summary: The Android lifecycle is weird: turns out `onActivityResult` is called before `onResume`. This means `getCurrentActivity()` could return the wrong instance, or `null` if the activity was destroyed. To give developers access to the Activity receiving the result (which is also about to become the current activity), pass it as an argumento the listener. Fixes github issue #8694. Reviewed By: donyu Differential Revision: D3704141 fbshipit-source-id: e7e00ccc28114f97415e5beab8c9b10cb1e530be
Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: > **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.** Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see Closes #9388 Differential Revision: D3715004 fbshipit-source-id: c12abcdd54ae1176aaf666eed520b85e2f8db6bd
Summary: Add docs to NavigationStateUtils. Reviewed By: ericvicenti Differential Revision: D3679295 fbshipit-source-id: 26fc1e4f39af58e11572b74b150e08b3094e36c6
Summary: Add documentation for NavigationCardStack Reviewed By: ericvicenti Differential Revision: D3685319 fbshipit-source-id: 6cd62195a434b3a7ed6b9cdca6fbd17212160ee2
Summary: This is a very hacky solution to make reloads from packager faster for simple file changes. Simple means that no dependencies have changed, otherwise packager will abort the attempt to update and fall back to the usual rebuilding method. In principle, this change avoids re-walking and analyzing the whole dependency tree, and just updates modules in existing bundles. Reviewed By: bestander Differential Revision: D3713704 fbshipit-source-id: ba182325c4f4003c0a7402ea87444a94c75ebaf8
Summary: I, like many before me, had to Google why react-native init appeared to hang the first time I tried it. It turns out it can just take a really long time, but does not give any warning of this fact. This patch provides such a warning. Closes #9406 Differential Revision: D3716357 Pulled By: bestander fbshipit-source-id: 6a460c881a20b9edb1bd1c8c5df09e5a7e5020ed
Summary: Explain the **motivation** for making this change. What existing problem does the pull request solve? The Android permissions native module was open sourced recently (b7352b4) but it is currently undocumented and requires directly interfacing with the native module. This provides a JS wrapper to make it easier to use the permissions module and documents it. This could be cleaner if the native code used Promise blocks instead of callbacks, but I didn't want to change the native code without a thumbs up since I'm guessing this is used in one of facebook's apps. Happy to do that if it makes sense I also tried to make the `PERMISSIONS` object a class property - it works in the actual code but not in the documentation (think it's a jsdocs problem), so decided to initialize in the constructor. **Test plan (required)** If the API looks good, I will change the UIExplorer example to use this. cc andreicoman11 Closes #9292 Differential Revision: D3716303 Pulled By: andreicoman11 fbshipit-source-id: cd40b8757fdf70ea8faecfb58caa00e99a99789e
Summary: This clears the packager server cache for potential changes of module resolutions. We will make this a lot better in the future, but for now this crude mechanism will have to do. Reviewed By: cpojer Differential Revision: D3713143 fbshipit-source-id: 7c81f40e8ec71404c3369211b29f63928d6634b9
Summary: Fix for issue #3652 - Converting from `int` to `float` is lossy for very large numbers, so storing `borderColor` as a single `Spacing` object (which uses `float`) was not working for certain colors. So, this pull request splits `borderColor` into alpha and RGB components, and stores each of these as their own respective `Spacing` objects. *Test Plan* Check out cosmith sample code here that triggers the bug: https://rnplay.org/apps/l1bw2A What currently looks like this: <img width="548" alt="screen shot 2016-08-13 at 6 22 28 pm" src="https://cloud.githubusercontent.com/assets/1630466/17645965/9346f05e-6183-11e6-8d40-3e458b08fd9a.png"> Should look like this (with my fix applied): <img width="543" alt="screen shot 2016-08-13 at 6 20 08 pm" src="https://cloud.githubusercontent.com/assets/1630466/17645968/9c26d1d0-6183-11e6-8759-75a5e99f498a.png"> Closes #9380 Differential Revision: D3716707 Pulled By: foghina fbshipit-source-id: 1164378112e2a58d43c8f5fc671c2efdb64b412b
Reviewed By: IanChilds Differential Revision: D3714510 fbshipit-source-id: f6d0436346416aab023aacbedd70ea189e583e8d
Reviewed By: IanChilds Differential Revision: D3714512 fbshipit-source-id: 4c42d52b3ab92903e9e9451df0ca1564e2d33f0f
Reviewed By: lucasr Differential Revision: D3714520 fbshipit-source-id: 80d3a9a1e2b6f74b863bbe22357f2c9865fa290e
Reviewed By: lucasr Differential Revision: D3715201 fbshipit-source-id: ea81ed426f0f7853bb542355c01fc16ae4360238
Reviewed By: andreicoman11 Differential Revision: D3655436 fbshipit-source-id: 3ca6535cd819171867c79f5e9801d9013676a80f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with upstream