Webview: Fixed broken fullscreen modals due to zero body height. #8536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @mkonicek and @nicklockwood to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
Contributor
|
Does this commit also fix this issue? - #5211 |
Contributor
Author
Contributor
|
@danielbraun awesome. will shipit as soon as the tests pass. |
ghost
added
the
CLA Signed
Contributor
|
@danielbraun Hey. Sorry forgot to merge this. Now it seems that this has different changes. Can you fix it please and ping me? |
ghost
added
the
CLA Signed
Contributor
Author
ghost
added
the
CLA Signed
Contributor
Author
ghost
pushed a commit
that referenced
this pull request
Jul 27, 2016
Summary: Supersedes PR #8536 Fixes #5211 JavaScript plugins such as Fotorama are broken when attempting use its fullscreen feature. If there's an absolute HTML element with 100% height under <body>, its height is 0 when rendered in the Android WebView. This commit fixes it. Closes #8830 Reviewed By: bestander Differential Revision: D3632821 Pulled By: jamesgpearce fbshipit-source-id: c185bcd30d1d214a357d0d8552d61d0ddfa5e6c6
bartolkaruza
pushed a commit
to immidi/react-native
that referenced
this pull request
Aug 3, 2016
Summary: Supersedes PR facebook#8536 Fixes facebook#5211 JavaScript plugins such as Fotorama are broken when attempting use its fullscreen feature. If there's an absolute HTML element with 100% height under <body>, its height is 0 when rendered in the Android WebView. This commit fixes it. Closes facebook#8830 Reviewed By: bestander Differential Revision: D3632821 Pulled By: jamesgpearce fbshipit-source-id: c185bcd30d1d214a357d0d8552d61d0ddfa5e6c6
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Supersedes PR facebook#8536 Fixes facebook#5211 JavaScript plugins such as Fotorama are broken when attempting use its fullscreen feature. If there's an absolute HTML element with 100% height under <body>, its height is 0 when rendered in the Android WebView. This commit fixes it. Closes facebook#8830 Reviewed By: bestander Differential Revision: D3632821 Pulled By: jamesgpearce fbshipit-source-id: c185bcd30d1d214a357d0d8552d61d0ddfa5e6c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5211
JavaScript plugins such as Fotorama are broken when attempting use its fullscreen feature.
If there's an absolute HTML element with 100% height under
<body>, its height is 0 when rendered in the Android WebView.This commit fixes it.