Add downloadable .hex files to releases (and pushes) #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare against BOOT_ANIMATION_COUNT instead of using byte size of array (which I think it would resolve to 90)
Missing semicolon :O
Based on 46c875c, except it removes completely the usage of floor() we don't need.
TI*_Config are static to hk32f030m_tim.c
- Remove unnecessary linker flags - Pass -flto also as a linker flag - Remove warning on RWX segments with gcc 13
We're not using any libc function, so drop nano/nosys specs and use nostdlib directly. Stub _init() to get the default implementation of __libc_init_array.
Prevent a few delay loops from being elided
|
Hi, I just noticed this PR. Why are there 29 commits? Most of them seem to be completely unrleated to the hex files github actions. Can you please resubmit with only the relevant commits? |
|
Because
I'm happy to create a new PR with the GA only, but builds will fail there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was having trouble acquiring the hex file for the LCM module as I use Linux and the recommended way ( https://discord.com/channels/778267964239511644/1132304175783497919/1142888385816567839 ) to compile it depends on Keil μVision which is Windows only.
I used the work in PR #12 and added Github Actions support to compile the firmware for each battery variant