Cherry pick MTL loader fix #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: wrong parser behavior to Tr option with parameter invertTrProperty
dmarcos
pushed a commit
that referenced
this pull request
Feb 2, 2019
Update the changes form the origin repo.
|
Thanks. We can maybe try rebasing this branch on top of THREE dev branch? It will make it easier to keep it up to date in the future. vs. cherry picking commits. |
|
Just rebased and republish as |
|
This should have been fixed in master now. |
dmarcos
pushed a commit
that referenced
this pull request
Dec 1, 2019
.getPlane method needs a Plane as a target
dmarcos
pushed a commit
that referenced
this pull request
Mar 27, 2020
Newest dev from mrdoob's repo
dmarcos
pushed a commit
that referenced
this pull request
Mar 27, 2020
dmarcos
pushed a commit
that referenced
this pull request
Mar 27, 2020
dmarcos
pushed a commit
that referenced
this pull request
Nov 26, 2020
Read object name from .3dm file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry picks the commit from mrdoob#13685 to fix transparency with objs and resolve aframevr/aframe#3441
I've tested and this does resolve the referenced issue with
vive-controlsI included the updated build for convenience (
npm run build) so that A-Frame installs would start getting the fix automatically; happy to drop that commit and update the PR if you have a custom build process