Skip to content

Always log Link AB test exposures #11265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
+11 −14
Merged

Always log Link AB test exposures #11265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4935fb
Always log Link AB test exposures
mats-stripe Aug 5, 2025
cde3ec8
Update exposure logging unit tests
mats-stripe Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions paymentsheet/src/main/java/com/stripe/android/paymentsheet/state/PaymentElementLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,15 +273,11 @@ internal class DefaultPaymentElementLoader @Inject constructor(
state = state
)

// Only log Link AB Test if Link is enabled
val linkEnabled = state.paymentMethodMetadata.linkState != null
if (linkEnabled) {
logLinkHoldbackExperiment(
elementsSession = elementsSession,
state = state,
experimentAssignment = ElementsSession.ExperimentAssignment.LINK_AB_TEST
)
}
logLinkHoldbackExperiment(
elementsSession = elementsSession,
state = state,
experimentAssignment = ElementsSession.ExperimentAssignment.LINK_AB_TEST
)
}

private suspend fun retrieveElementsSession(
Expand Down
11 changes: 6 additions & 5 deletions ...et/src/test/java/com/stripe/android/paymentsheet/state/DefaultPaymentElementLoaderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3190,7 +3190,7 @@ internal class DefaultPaymentElementLoaderTest {
}

@Test
fun `Just Link holdback experiment is triggered when loading PaymentSheet and Link unavailable`() = runTest {
fun `Both Link holdback experiments are triggered when loading PaymentSheet when Link is unavailable`() = runTest {
val logLinkHoldbackExperiment = FakeLogLinkHoldbackExperiment()

val loader = createPaymentElementLoader(
Expand All @@ -3208,13 +3208,14 @@ internal class DefaultPaymentElementLoaderTest {
),
)

val item = logLinkHoldbackExperiment.calls.awaitItem()
assertThat(item.experiment).isEqualTo(ElementsSession.ExperimentAssignment.LINK_GLOBAL_HOLD_BACK)
logLinkHoldbackExperiment.calls.expectNoEvents()
val globalHoldback = logLinkHoldbackExperiment.calls.awaitItem()
assertThat(globalHoldback.experiment).isEqualTo(ElementsSession.ExperimentAssignment.LINK_GLOBAL_HOLD_BACK)
val abTest = logLinkHoldbackExperiment.calls.awaitItem()
assertThat(abTest.experiment).isEqualTo(ElementsSession.ExperimentAssignment.LINK_AB_TEST)
}

@Test
fun `Both Link holdback experiments are triggered when loading PaymentSheet`() = runTest {
fun `Both Link holdback experiments are triggered when loading PaymentSheet when Link is available`() = runTest {
val logLinkHoldbackExperiment = FakeLogLinkHoldbackExperiment()

val loader = createPaymentElementLoader(
Expand Down
Loading