Skip to content

Conversation

mats-stripe
Copy link
Contributor

Summary

Always log Link AB test exposures, instead of only when Link is enabled.

Motivation

https://stripe.slack.com/archives/C08P60QCL1W/p1754362038470109

Testing

Unit tests updated

Changelog

N/a

@mats-stripe mats-stripe requested review from a team as code owners August 5, 2025 14:18
Copy link
Contributor

github-actions bot commented Aug 5, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │  0 B │   457 KiB │   457 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │  0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │  0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.7 KiB │  95.7 KiB │ +1 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.4 MiB │  11.4 MiB │ +1 B │  25.3 MiB │  25.3 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20684 │ 20684 │ 0 (+0 -0) 
   types │  6503 │  6503 │ 0 (+0 -0) 
 classes │  5267 │  5267 │ 0 (+0 -0) 
 methods │ 31502 │ 31502 │ 0 (+0 -0) 
  fields │ 18232 │ 18232 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3648 │ 3648 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
    272 B │ +2 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 29.2 KiB │ +2 B │  64.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
 25.9 KiB │ -2 B │  64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
  1.2 KiB │ -1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 56.5 KiB │ +1 B │ 130.5 KiB │  0 B │ (total)

@mats-stripe mats-stripe closed this Aug 5, 2025
@mats-stripe mats-stripe reopened this Aug 5, 2025
@mats-stripe mats-stripe force-pushed the mats/always_log_link_ab_test branch from a57b156 to 0c4d465 Compare August 5, 2025 22:48
@mats-stripe mats-stripe force-pushed the mats/always_log_link_ab_test branch from 0c4d465 to cde3ec8 Compare August 6, 2025 18:54
@mats-stripe mats-stripe closed this Aug 6, 2025
@mats-stripe mats-stripe reopened this Aug 6, 2025
@mats-stripe mats-stripe closed this Aug 6, 2025
@mats-stripe mats-stripe reopened this Aug 6, 2025
@mats-stripe mats-stripe merged commit 969f44a into master Aug 7, 2025
29 of 31 checks passed
@mats-stripe mats-stripe deleted the mats/always_log_link_ab_test branch August 7, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants