chore: Cherry-picked changes from upstream #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* document node.js version * nit
…ng + include `arm64` (#87) * add test matrix from foundry-rs/foundry-toolchain#85 * os.arch() can not return x32, also return arm64, cannot return aarch64 as suggested in foundry-rs/foundry-toolchain#85
…ng + include `arm64` (#87) * add test matrix from foundry-rs/foundry-toolchain#85 * os.arch() can not return x32, also return arm64, cannot return aarch64 as suggested in foundry-rs/foundry-toolchain#85
Contributor
Author
|
🚀 PR Updated! The PR has been updated with the latest cherry-picked commits. @step-security/maintained-actions-dev Please review and approve the changes. 📦 Target Release Version:
|
|
Claude finished @github-actions[bot]'s task —— View job PR Review: Cherry-picked Changes AnalysisTodo List:
🟡 CHERRY-PICK STATUS: IMPROVED BUT INCOMPLETEBased on my analysis, this PR has significantly improved from the previous verification reports, but still has some issues: ✅ RESOLVED ISSUES (Previously Missing, Now Present)
❌ REMAINING ISSUES
📋 CHANGES ANALYSISSource Code Changes - ✅ SECUREFile: // Line 4: normalizeVersionName function
return version.replace(/^nightly-[0-9a-f]{40}$/, "nightly");Security Status: ✅ SAFE
Version Updates - ✅ CONSISTENT
Configuration Files - ✅ CLEAN
version: 2
updates:
- package-ecosystem: github-actions
directory: /
schedule:
interval: daily
- package-ecosystem: npm
directory: /
schedule:
interval: dailyStatus: ❌ Previous duplicate content issue has been resolved Workflow Changes -
|
Contributor
Author
🔍 Cherry-Pick Verification Report📦 Upstream Changes: 📋 File-by-File Analysis:
|
Raj-StepSecurity
previously approved these changes
Oct 29, 2025
.github/workflows/ci.yml
Outdated
| on: | ||
| pull_request: | ||
| branches: | ||
| - master |
.github/workflows/ci.yml
Outdated
| - "**.md" | ||
| push: | ||
| branches: | ||
| - master |
Raj-StepSecurity
approved these changes
Oct 29, 2025
|
Claude encountered an error —— View job PR Review: Cherry-picked Changes AnalysisTodo List:
🟡 CHERRY-PICK STATUS: MOSTLY COMPLETE WITH MINOR GAPSAfter analyzing all files in this PR, the cherry-pick is significantly improved compared to earlier verification reports, but has one remaining issue. ✅ SUCCESSFULLY CHERRY-PICKED
❌ REMAINING ISSUE
🔍 DETAILED ANALYSISSource Code Changes - ✅ SECUREFile: function normalizeVersionName(version) {
return version.replace(/^nightly-[0-9a-f]{40}$/, "nightly");
}Security Status: ✅ SAFE
Workflow Configuration - ✅ ROBUSTFile:
Dependency Management - ✅ CLEANFile: version: 2
updates:
- package-ecosystem: github-actions
directory: /
schedule:
interval: daily
- package-ecosystem: npm
directory: /
schedule:
interval: dailyStatus: ✅ Well-formed YAML, no duplicates or syntax issues Version Consistency - ✅ ALIGNED
Documentation Updates - ✅ COMPREHENSIVEFile:
Build Artifacts - ✅ SYNCHRONIZED
🛡️ SECURITY ANALYSIS: PASSEDCode Security: ✅ ALL CLEAR
Configuration Security: ✅ COMPLIANT
📊 COMPLETENESS ASSESSMENTCherry-Pick Quality: 🟡 95% Complete
🎯 RECOMMENDATIONStatus: 🟡 CONDITIONAL APPROVALThis PR is nearly complete and can be approved once the missing Required Action:
Optional Verification:
Overall Quality: ✅ High-quality cherry-pick with comprehensive testing |
Contributor
Author
🔍 Cherry-Pick Verification Report📦 Upstream Changes: 📋 File-by-File Analysis:
|
|
Claude finished @github-actions[bot]'s task —— View job PR Review: Cherry-picked Changes AnalysisTodo List:
🟡 CHERRY-PICK STATUS: MOSTLY COMPLETE WITH ONE MISSING FILEBased on my analysis and the verification reports, this PR has significantly improved from previous attempts but still has one outstanding issue. ✅ SUCCESSFULLY CHERRY-PICKED
❌ REMAINING ISSUE
🔍 DETAILED ANALYSISSource Code Changes - ✅ SECUREFile: function normalizeVersionName(version) {
return version.replace(/^nightly-[0-9a-f]{40}$/, "nightly");
}Security Status: ✅ SAFE
Workflow Configuration - ✅ ROBUSTFile:
Dependency Management - ✅ CLEANFile: version: 2
updates:
- package-ecosystem: github-actions
directory: /
schedule:
interval: daily
- package-ecosystem: npm
directory: /
schedule:
interval: dailyStatus: ✅ Well-formed YAML, no duplicates or syntax issues Version Consistency - ✅ ALIGNED
Documentation Updates - ✅ COMPREHENSIVEFile:
Build Artifacts - ✅ SYNCHRONIZED
🛡️ SECURITY ANALYSIS: PASSEDCode Security: ✅ ALL CLEAR
Configuration Security: ✅ COMPLIANT
📊 COMPLETENESS ASSESSMENTCherry-Pick Quality: 🟡 95% Complete
🎯 RECOMMENDATIONStatus: 🟡 CONDITIONAL APPROVALThis PR is nearly complete and can be approved once the missing Required Action:
Optional Verification:
Overall Quality: ✅ High-quality cherry-pick with comprehensive testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked changes from upstream.