feat: add ARM64 support and comprehensive CI testing #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add arm64/aarch64 architecture mapping in utils.js - Add CI matrix testing all platforms: Linux/macOS/Windows on x64/ARM64 - Test both stable and nightly Foundry versions (10 total jobs)
shuhuiluo
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
Member
|
Thanks @shuhuiluo for your PR! I've integrated it into #87 with some additonal changes |
github-actions bot
added a commit
to step-security/foundry-toolchain
that referenced
this pull request
Oct 17, 2025
…ng + include `arm64` (#87) * add test matrix from foundry-rs/foundry-toolchain#85 * os.arch() can not return x32, also return arm64, cannot return aarch64 as suggested in foundry-rs/foundry-toolchain#85
github-actions bot
added a commit
to step-security/foundry-toolchain
that referenced
this pull request
Oct 17, 2025
…ng + include `arm64` (#87) * add test matrix from foundry-rs/foundry-toolchain#85 * os.arch() can not return x32, also return arm64, cannot return aarch64 as suggested in foundry-rs/foundry-toolchain#85
s-forgelabmk96
added a commit
to s-forgelabmk96/foundry-toolchain
that referenced
this pull request
Oct 28, 2025
…ng + include `arm64` (#87) * add test matrix from foundry-rs/foundry-toolchain#85 * os.arch() can not return x32, also return arm64, cannot return aarch64 as suggested in foundry-rs/foundry-toolchain#85
al2016s
added a commit
to al2016s/toolchain
that referenced
this pull request
Nov 1, 2025
…ng + include `arm64` (#87) * add test matrix from foundry-rs/foundry-toolchain#85 * os.arch() can not return x32, also return arm64, cannot return aarch64 as suggested in foundry-rs/foundry-toolchain#85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am aware of issue #76. But this is a quick fix to support ARM64 runners which have been supported since Aug 7th or earlier. It also adds comprehensive CI testing for all relevant platforms.
Changes