You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROX_COLLECTOR_SET_IMPORT_USERS defaults to false, and is used to configure sinsp and its user-mgmt subsystem.
This is intended as a safeguard in case we would need to reenable it; and was deactivated to circumvent a memory management issue (CRI not available => containers never freed in user.cpp)
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist
Investigated and inspected CI test results
Setting the env var changes the config and can be seen in the logs
ROX_COLLECTOR_SET_IMPORT_USERS defaults to false, and is used
to configure sinsp and its user-mgmt subsystem.
This is intended as a safeguard in case we would need to reenable
it; and was deactivated to circumvent a memory management issue
(CRI not available => containers never freed in user.cpp)
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Looks good, but probably ...SET... is not needed. sinsp uses it as verb, so ROX_COLLECTOR_IMPORT_USERS would be more straightforward.
It makes sense. I based my choice on the CURL flag, since it is similarly setting configuration for an other component, whereas flags like the core_bpf hard fail are behaviors of the collector logic itself.
Looks good, but probably ...SET... is not needed. sinsp uses it as verb, so ROX_COLLECTOR_IMPORT_USERS would be more straightforward.
It makes sense. I based my choice on the CURL flag, since it is similarly setting configuration for an other component, whereas flags like the core_bpf hard fail are behaviors of the collector logic itself.
Ah, I see. There seems to be some inconsistency here, so I don't mind it be either way.
ROX_COLLECTOR_SET_IMPORT_USERS defaults to false, and is used
to configure sinsp and its user-mgmt subsystem.
This is intended as a safeguard in case we would need to reenable
it; and was deactivated to circumvent a memory management issue
(CRI not available => containers never freed in user.cpp)
* Disable the import-users flag (#1186)
When the CRI is not available, the containers are never declared
destroyed; and the user-manager keeps user information forever.
* New environment variable to control set_import_users() (#1189)
ROX_COLLECTOR_SET_IMPORT_USERS defaults to false, and is used
to configure sinsp and its user-mgmt subsystem.
This is intended as a safeguard in case we would need to reenable
it; and was deactivated to circumvent a memory management issue
(CRI not available => containers never freed in user.cpp)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ROX_COLLECTOR_SET_IMPORT_USERS defaults to false, and is used to configure sinsp and its user-mgmt subsystem.
This is intended as a safeguard in case we would need to reenable it; and was deactivated to circumvent a memory management issue (CRI not available => containers never freed in user.cpp)
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist