Skip to content

Disable the import-users flag #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2023
Merged

Disable the import-users flag #1186

merged 1 commit into from
Jun 2, 2023

Conversation

ovalenti
Copy link
Contributor

@ovalenti ovalenti commented Jun 2, 2023 •
edited
Loading

Description

When the CRI is not available, the containers are never declared destroyed; and the user-manager keeps user information forever.

Checklist

  • Investigated and inspected CI test results

Testing Performed

The memory allocation growth can be accelerated with:

while true; do kubectl run temp -i -t --image=debian:bookworm --rm --restart=Never --command -- sleep 1; done

@ovalenti
Disable the import-users flag
762a874 
When the CRI is not available, the containers are never declared
destroyed; and the user-manager keeps user information forever.
@ovalenti ovalenti self-assigned this Jun 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue
rhel.rhel-8 ebpf 232.014 239.533 204.92 213.7 🟢
ubuntu-os.ubuntu-1804-lts ebpf 185.617 164.317 206.11 213.49 🟢
ubuntu-os.ubuntu-2004-lts ebpf 209.243 184.609 236.1 234.97 🟢
ubuntu-os.ubuntu-2204-lts ebpf 143.781 148.489 222.56 229.05 🟢

@ovalenti ovalenti marked this pull request as ready for review June 2, 2023 13:16
@ovalenti ovalenti requested a review from a team as a code owner June 2, 2023 13:16
Stringy
Stringy approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ovalenti ovalenti merged commit 1ca2954 into master Jun 2, 2023
@ovalenti ovalenti deleted the ovalenti/ROX-17096-disable_import-users branch June 2, 2023 17:06
@ovalenti ovalenti mentioned this pull request Jun 5, 2023
Closed
5 tasks
ovalenti added a commit that referenced this pull request Jun 6, 2023
@ovalenti
Disable the import-users flag (#1186)
f77b076 
When the CRI is not available, the containers are never declared
destroyed; and the user-manager keeps user information forever.
@ovalenti ovalenti mentioned this pull request Jun 6, 2023
Merged
1 task
ovalenti added a commit that referenced this pull request Jun 15, 2023
@ovalenti
ROX-17553 Backport disable/control of the user-import feature (#1192)
57759bf 
* Disable the import-users flag (#1186)

When the CRI is not available, the containers are never declared
destroyed; and the user-manager keeps user information forever.

* New environment variable to control set_import_users() (#1189)

ROX_COLLECTOR_SET_IMPORT_USERS defaults to false, and is used
to configure sinsp and its user-mgmt subsystem.

This is intended as a safeguard in case we would need to reenable
it; and was deactivated to circumvent a memory management issue
(CRI not available => containers never freed in user.cpp)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stringy Stringy Stringy approved these changes

Assignees

@ovalenti ovalenti

Labels
all-integration-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ovalenti @Stringy