Fix release workflow #3764
Merged
Fix release workflow #3764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
azdagron
commented
Jan 13, 2023
azdagron
commented
- Fixes a recent regression in permissions on the publish-artifact job (introduced by Limit workflow job permissions to bare minimum #3706).
- Makes image publishing rely on the same jobs as artifact publishing so that we don't publish images but fail to publish the release if there is a failure in the windows jobs.
- Fixes a recent regression in permissions on the publish-artifact job (introduced by spiffe#3706). - Makes image publishing rely on the same jobs as artifact publishing so that we don't publish images but fail to publish the release if there is a failure in the windows jobs. Signed-off-by: Andrew Harding <[email protected]>
azdagron
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
rturner3
approved these changes
Jan 13, 2023
stevend-uber
pushed a commit
to stevend-uber/spire
that referenced
this pull request
Oct 16, 2023
- Fixes a recent regression in permissions on the publish-artifact job (introduced by spiffe#3706). - Makes image publishing rely on the same jobs as artifact publishing so that we don't publish images but fail to publish the release if there is a failure in the windows jobs. Signed-off-by: Andrew Harding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.