Fix release workflow (#3764)

- Fixes a recent regression in permissions on the publish-artifact job
  (introduced by #3706).
- Makes image publishing rely on the same jobs as artifact publishing so
  that we don't publish images but fail to publish the release if there
  is a failure in the windows jobs.

Signed-off-by: Andrew Harding <[email protected]>

Author: azdagron

.github/workflows/release_build.yaml

@@ -542,7 +542,7 @@ jobs:
             lint-windows, unit-test-windows, artifact-windows, integration-windows]
 
     permissions:
-      contents: read
+      contents: write
 
     steps:
       - name: Checkout
@@ -566,7 +566,8 @@ jobs:
 
   publish-images:
     runs-on: ubuntu-20.04
-    needs: [lint, unit-test, unit-test-race-detector, artifacts, integration]
+    needs: [lint, unit-test, unit-test-race-detector, artifacts, integration,
+            lint-windows, unit-test-windows, artifact-windows, integration-windows]
 
     permissions:
       contents: read