Add support for annotating the various services #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
feature/add-support-service-annotations
branch
from
1c7111b to
9fcf0b2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
@tonyhogsten could you run |
|
@phillebaba I ran make helm-docs again now. Seems I changed an URL manually due to my OCD of seeing the markdown warning which was now reverted. Hopefully it will work better now? |
phillebaba
force-pushed
the
feature/add-support-service-annotations
branch
from
d91a862 to
ca15107
Compare
phillebaba
force-pushed
the
feature/add-support-service-annotations
branch
from
ca15107 to
eea57ef
Compare
phillebaba
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this feature request: #966, created by me, I have added support in the helm chart to be able to set annotations on the various services.
I have run the linter;
helm lint charts/spegel
==> Linting charts/spegel
[INFO] Chart.yaml: icon is recommended
1 chart(s) linted, 0 chart(s) failed
Fixes #966