Ability to set annotations on service

[tonyhogsten]

Describe the problem to be solved

Hello,

I have a need to set annotations on the service created, for metrics, due to us using a custom scraper which acts based on the annotations set on the service. There seems to be no ability to do so in the helm chart, and I would appreciate adding this capability.

Thank you

Proposed solution to the problem

No response

[phillebaba]

What annotation do you specifically need for your metrics scraper? In your PR you added annotations to all the services, which I do not think is necessary. Trying to see if there is some standard simple method to solve your issue.

[tonyhogsten]

Hey!

Yeah sure. In this case we're using the prometheus scrape annotations (Well, not entirely true because we've customized them slightly and use differently names annotations but the principal is the same).

https://prometheus.io/docs/prometheus/latest/configuration/configuration/
https://nttdata-dach.github.io/posts/mjm-sa-otelmetrics-03-annotationbasedscraping/

And we use the open-telemetry operator to create a scraper. We send them through our specific pipeline in order to add certain things we need on the metrics and can't/won't use the ama-metrics server and the ServiceMonitor for it.

I added the annotations to all the services because I thought it would be good to be consistent, but it's true I personally only need to be able to annotate the metric service.

[phillebaba]

I actually changed my mind, had a look at some other Helm charts out there and this seems like a common practice to expose setting service annotations, so we can go ahead with it.

[phillebaba]

Fixed in #967