MRG: enable loading manifest files #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ash_plugin_branchwater into use-core-more-broadly
bluegenes
changed the title
|
(these are standalone manifests as output by |
|
ahh! I see it in the docs :) |
ctb
approved these changes
Feb 13, 2024
|
nice! |
This was referenced Feb 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor sequential loading attempts in
load_collectionfor individual functions that can propagate errors. Addcollection_from_manifestto allow loading a manifest file directly.Loading a manifest is a much better alternative to loading a pathlist, since it allows lazy loading -- i.e. we don't need to load all signatures immediately to obtain parameters for selection.