Skip to content

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Mar 14, 2025

Description

Fixes #2758

#2466 removed old workaround for header config blocking gestures - we just set top: -100%
to place the headerconfig in the top of the screen effectively preventing blocking.

#2466 removed these styles & frame correction is now applied directly in shadow node. This is done fine
on Fabric, however the solution was not replicated on Paper.

Changes

Beside padding information we now send native toolbar height to header config shadow node on Paper.
This information is used there to offset the header config position by this value.

Should solve the problem.

Screenshots

before after
before after

Test code and steps to reproduce

Example -> Header options -> click on the very top button (very top of it). Previously the button was not effectively
clicked. Now it works.

Checklist

@kkafar kkafar merged commit 1cbdb33 into main Mar 14, 2025
4 checks passed
@kkafar kkafar deleted the @kkafar/android-header-config-blocks-gestures branch March 14, 2025 13:39
@b1ngx
Copy link

b1ngx commented Mar 19, 2025

headerShown: false still has this issue.

@kkafar
Copy link
Member Author

kkafar commented Mar 19, 2025

@b1ngx thanks, looking into it

@kkafar
Copy link
Member Author

kkafar commented Mar 19, 2025

@b1ngx I'm not sure whether this is a bug. The only behaviour I reproduce is as on the recording.
All clicks are accepted, except ones that go through status bar + this behaviour is consistent across old & new architecture.

Even if I disable the header config completely, the area covered by status bar is still not clickable.

Ping me, in case you meant some different behaviour.

(old architecture)

Screen.Recording.2025-03-19.at.11.03.53.mov

@b1ngx
Copy link

b1ngx commented Mar 20, 2025

@kkafar
Copy link
Member Author

kkafar commented Mar 20, 2025

That's great, thanks! I'll look into it shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScreenStackHeaderConfig masks the SceneScreen area when customizing the header component
2 participants