fix(Android,Paper): header config blocks gestures close to the top of the screen #2781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2758
#2466 removed old workaround for header config blocking gestures - we just set top:
-100%
to place the headerconfig in the top of the screen effectively preventing blocking.
#2466 removed these styles & frame correction is now applied directly in shadow node. This is done fine
on Fabric, however the solution was not replicated on Paper.
Changes
Beside padding information we now send native toolbar height to header config shadow node on Paper.
This information is used there to offset the header config position by this value.
Should solve the problem.
Screenshots
Test code and steps to reproduce
Example
->Header options
-> click on the very top button (very top of it). Previously the button was not effectivelyclicked. Now it works.
Checklist