fix(iOS): Change import of RectUtil.h file to react/renderer/components #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboba
changed the title
matinzd
approved these changes
Aug 26, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…ts (software-mansion#2319) ## Description In the newest version of screens, there's a bug where compiler can't find RectUtil.h file from `utils/RectFile.h` during the compile phase of RNSScreenComponentDescriptor file. This PR fixes this by changing the path of RectUtil.h file to <react/renderer/components/rnscreens/util/RectFile.h> file. Fixes software-mansion#2306. ## Changes - Changed import of RectUtil.h file in RNSScreenComponentDescriptor.h file ## Test code and steps to reproduce - Download reproducer from https://github.com/jankosecki/react-native-upgrade-tester/tree/rn-0.75 - Delete patches/react-native-screens+3.34.0.patch - Clean up node_modules in case patch already applied - Run yarn setup (it invokes "pod-install": "(cd ./ios ; RCT_NEW_ARCH_ENABLED=1 USE_FRAMEWORKS=static bundle exec pod install --repo-update)" which enables new architecture) - Open XCode to set up development team (provided repro contains None team in Signing & Capabilities) - Run yarn start - Run yarn ios or trigger build from XCode (yarn ios causes a massive error output with different "error" lines but XCode offers a clear reason. ## Checklist - [ ] Ensured that CI passes
alduzy
pushed a commit
that referenced
this pull request
Oct 25, 2024
…ts (#2319) ## Description In the newest version of screens, there's a bug where compiler can't find RectUtil.h file from `utils/RectFile.h` during the compile phase of RNSScreenComponentDescriptor file. This PR fixes this by changing the path of RectUtil.h file to <react/renderer/components/rnscreens/util/RectFile.h> file. Fixes #2306. ## Changes - Changed import of RectUtil.h file in RNSScreenComponentDescriptor.h file ## Test code and steps to reproduce - Download reproducer from https://github.com/jankosecki/react-native-upgrade-tester/tree/rn-0.75 - Delete patches/react-native-screens+3.34.0.patch - Clean up node_modules in case patch already applied - Run yarn setup (it invokes "pod-install": "(cd ./ios ; RCT_NEW_ARCH_ENABLED=1 USE_FRAMEWORKS=static bundle exec pod install --repo-update)" which enables new architecture) - Open XCode to set up development team (provided repro contains None team in Signing & Capabilities) - Run yarn start - Run yarn ios or trigger build from XCode (yarn ios causes a massive error output with different "error" lines but XCode offers a clear reason. ## Checklist - [ ] Ensured that CI passes
kkafar
pushed a commit
that referenced
this pull request
Oct 25, 2024
…ts (#2319) ## Description In the newest version of screens, there's a bug where compiler can't find RectUtil.h file from `utils/RectFile.h` during the compile phase of RNSScreenComponentDescriptor file. This PR fixes this by changing the path of RectUtil.h file to <react/renderer/components/rnscreens/util/RectFile.h> file. Fixes #2306. ## Changes - Changed import of RectUtil.h file in RNSScreenComponentDescriptor.h file ## Test code and steps to reproduce - Download reproducer from https://github.com/jankosecki/react-native-upgrade-tester/tree/rn-0.75 - Delete patches/react-native-screens+3.34.0.patch - Clean up node_modules in case patch already applied - Run yarn setup (it invokes "pod-install": "(cd ./ios ; RCT_NEW_ARCH_ENABLED=1 USE_FRAMEWORKS=static bundle exec pod install --repo-update)" which enables new architecture) - Open XCode to set up development team (provided repro contains None team in Signing & Capabilities) - Run yarn start - Run yarn ios or trigger build from XCode (yarn ios causes a massive error output with different "error" lines but XCode offers a clear reason. ## Checklist - [ ] Ensured that CI passes (cherry picked from commit 80dcad4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the newest version of screens, there's a bug where compiler can't find RectUtil.h file from
utils/RectFile.hduring the compile phase of RNSScreenComponentDescriptor file.This PR fixes this by changing the path of RectUtil.h file to <react/renderer/components/rnscreens/util/RectFile.h> file.
Fixes #2306.
Changes
Test code and steps to reproduce
Checklist