Skip to content

Commit 0cafdc7

Browse files
tbobaalduzy
authored andcommitted
fix(iOS): Change import of RectUtil.h file to react/renderer/components (#2319)
## Description In the newest version of screens, there's a bug where compiler can't find RectUtil.h file from `utils/RectFile.h` during the compile phase of RNSScreenComponentDescriptor file. This PR fixes this by changing the path of RectUtil.h file to <react/renderer/components/rnscreens/util/RectFile.h> file. Fixes #2306. ## Changes - Changed import of RectUtil.h file in RNSScreenComponentDescriptor.h file ## Test code and steps to reproduce - Download reproducer from https://github.com/jankosecki/react-native-upgrade-tester/tree/rn-0.75 - Delete patches/react-native-screens+3.34.0.patch - Clean up node_modules in case patch already applied - Run yarn setup (it invokes "pod-install": "(cd ./ios ; RCT_NEW_ARCH_ENABLED=1 USE_FRAMEWORKS=static bundle exec pod install --repo-update)" which enables new architecture) - Open XCode to set up development team (provided repro contains None team in Signing & Capabilities) - Run yarn start - Run yarn ios or trigger build from XCode (yarn ios causes a massive error output with different "error" lines but XCode offers a clear reason. ## Checklist - [ ] Ensured that CI passes
1 parent 6fa792c commit 0cafdc7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
#endif
66
#include <react/debug/react_native_assert.h>
77
#include <react/renderer/components/rnscreens/Props.h>
8+
#include <react/renderer/components/rnscreens/utils/RectUtil.h>
89
#include <react/renderer/core/ConcreteComponentDescriptor.h>
910
#include "RNSScreenShadowNode.h"
10-
#include "utils/RectUtil.h"
1111

1212
namespace facebook {
1313
namespace react {

0 commit comments

Comments
 (0)