Bumping numpy version for Mac M1 compat #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rsmith49
force-pushed
the
update-numpy-version
branch
from
e5a8b53 to
fb42ee9
Compare
rsmith49
force-pushed
the
update-numpy-version
branch
from
fb42ee9 to
cec6723
Compare
* update python version * py38 test now passes * fix mypy check errors * add more comment in code
|
@rsmith49 I think merging this PR will help py37 and py38 CI builds |
* update python version * py38 test now passes * fix mypy check errors * add more comment in code * fix mypy error * remove unused import
|
@zexuan-zhou thanks for all the dev effort here! Looks like we addressed the mypy issues - ready for a review @bhancock8 |
bhancock8
approved these changes
Apr 13, 2022
|
@bhancock8 @rsmith49 Will there be a version release for this or what version should I use to install the latest version. Thank you |
akode
pushed a commit
to akode/snorkel
that referenced
this pull request
Jun 10, 2022
* Bumping numpy version for Mac M1 compat * update python version * fix mypy check errors Co-authored-by: Bruce Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
According to #1689, numpy versions lower than 1.21 are not supported by the new Mac M1 chips. Bumping the upper bound of numpy to accommodate this.
Related issue(s)
Fixes #1689
Test plan
Checklist
Need help on these? Just ask!
tox -e complexand/ortox -e sparkif appropriate.